fix: empty tmp dir instead of removing it (#2203)

* fix: empty tmp dir instead of removing it

The tmp directory is used for a number of things including
when editig k8s resources using kubectl edit. Removing it
after running commands will lead to failures in certain
commands.

Signed-off-by: Evans Mungai <evans@replicated.com>

* Better error message when reading tmp dir

Signed-off-by: Evans Mungai <evans@replicated.com>

* Use helpers.RemoveAll to empty the tmp dir

Signed-off-by: Evans Mungai <evans@replicated.com>

* Remove unnecessary test file

Signed-off-by: Evans Mungai <evans@replicated.com>

---------

Signed-off-by: Evans Mungai <evans@replicated.com>

Author: banjoh

pkg/runtimeconfig/runtimeconfig.go

@@ -6,6 +6,7 @@ import (
 	"path/filepath"
 
 	ecv1beta1 "github.com/replicatedhq/embedded-cluster/kinds/apis/v1beta1"
+	"github.com/replicatedhq/embedded-cluster/pkg/helpers"
 	"github.com/sirupsen/logrus"
 	"sigs.k8s.io/yaml"
 )
@@ -27,7 +28,13 @@ func Get() *ecv1beta1.RuntimeConfigSpec {
 }
 
 func Cleanup() {
-	os.RemoveAll(EmbeddedClusterTmpSubDir())
+	tmpDir := EmbeddedClusterTmpSubDir()
+	// We should not delete the tmp dir, rather we should empty its contents leaving
+	// it in place. This is because commands such as `kubectl edit <resource>`
+	// will create files in the tmp dir
+	if err := helpers.RemoveAll(tmpDir); err != nil {
+		logrus.Errorf("error removing %s dir: %s", tmpDir, err)
+	}
 }
 
 // EmbeddedClusterHomeDirectory returns the parent directory. Inside this parent directory we