chore(tests): adding tests to the host preflights logic (#2302)

* chore(tests): adding integration tests to the host preflights logic

* chore(tests): create preflight interface and fix the preflight integration tests

* chore(tests): add tests to the whole manager piece too

* chore: cleanup mocks

* chore(tests): fix flaky test

* chore: trying to make CI happy

* chore: rename

* chore: rename file

* chore: finally make the linter happy

Author: JGAntunes

api/controllers/install/controller.go

@@ -171,7 +171,7 @@ func NewInstallController(opts ...InstallControllerOption) (*InstallController,
 			preflight.WithRuntimeConfig(controller.rc),
 			preflight.WithLogger(controller.logger),
 			preflight.WithMetricsReporter(controller.metricsReporter),
-			preflight.WithHostPreflight(controller.install.Steps.HostPreflight),
+			preflight.WithHostPreflightStore(preflight.NewMemoryStore(controller.install.Steps.HostPreflight)),
 		)
 	}
 

api/integration/auth_controller_test.go

@@ -14,6 +14,7 @@ import (
 	"github.com/replicatedhq/embedded-cluster/api/controllers/install"
 	"github.com/replicatedhq/embedded-cluster/api/internal/managers/installation"
 	"github.com/replicatedhq/embedded-cluster/api/pkg/logger"
+	"github.com/replicatedhq/embedded-cluster/api/pkg/utils"
 	"github.com/replicatedhq/embedded-cluster/api/types"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
@@ -29,7 +30,7 @@ func TestAuthLoginAndTokenValidation(t *testing.T) {
 	// Create an install controller
 	installController, err := install.NewInstallController(
 		install.WithInstallationManager(installation.NewInstallationManager(
-			installation.WithNetUtils(&mockNetUtils{ifaces: []string{"eth0", "eth1"}}),
+			installation.WithNetUtils(&utils.MockNetUtils{}),
 		)),
 	)
 	require.NoError(t, err)

api/integration/console_test.go

@@ -2,7 +2,6 @@ package integration
 
 import (
 	"encoding/json"
-	"errors"
 	"net/http"
 	"net/http/httptest"
 	"testing"
@@ -11,17 +10,19 @@ import (
 	"github.com/replicatedhq/embedded-cluster/api"
 	"github.com/replicatedhq/embedded-cluster/api/controllers/console"
 	"github.com/replicatedhq/embedded-cluster/api/pkg/logger"
+	"github.com/replicatedhq/embedded-cluster/api/pkg/utils"
 	"github.com/replicatedhq/embedded-cluster/api/types"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 )
 
 func TestConsoleListAvailableNetworkInterfaces(t *testing.T) {
-	netutils := &mockNetUtils{ifaces: []string{"eth0", "eth1"}}
+	netUtils := &utils.MockNetUtils{}
+	netUtils.On("ListValidNetworkInterfaces").Return([]string{"eth0", "eth1"}, nil).Once()
 
 	// Create a console controller
 	consoleController, err := console.NewConsoleController(
-		console.WithNetUtils(netutils),
+		console.WithNetUtils(netUtils),
 	)
 	require.NoError(t, err)
 
@@ -62,11 +63,12 @@ func TestConsoleListAvailableNetworkInterfaces(t *testing.T) {
 }
 
 func TestConsoleListAvailableNetworkInterfacesUnauthorized(t *testing.T) {
-	netutils := &mockNetUtils{ifaces: []string{"eth0", "eth1"}}
+	netUtils := &utils.MockNetUtils{}
+	netUtils.On("ListValidNetworkInterfaces").Return([]string{"eth0", "eth1"}, nil).Once()
 
 	// Create a console controller
 	consoleController, err := console.NewConsoleController(
-		console.WithNetUtils(netutils),
+		console.WithNetUtils(netUtils),
 	)
 	require.NoError(t, err)
 
@@ -103,11 +105,12 @@ func TestConsoleListAvailableNetworkInterfacesUnauthorized(t *testing.T) {
 
 func TestConsoleListAvailableNetworkInterfacesError(t *testing.T) {
 	// Create a mock that returns an error
-	netutils := &mockNetUtils{err: errors.New("failed to list network interfaces")}
+	netUtils := &utils.MockNetUtils{}
+	netUtils.On("ListValidNetworkInterfaces").Return(nil, assert.AnError).Once()
 
 	// Create a console controller
 	consoleController, err := console.NewConsoleController(
-		console.WithNetUtils(netutils),
+		console.WithNetUtils(netUtils),
 	)
 	require.NoError(t, err)