chore(web): fix local web dev setup (#2229)

Author: JGAntunes

web/static.go

@@ -129,7 +129,7 @@ func (web *Web) RegisterRoutes(router *mux.Router) {
 
 	var webFS http.Handler
 	if os.Getenv("EC_DEV_ENV") == "true" {
-		webFS = http.FileServer(http.FS(os.DirFS("./web/dist/assets")))
+		webFS = http.FileServer(http.FS(os.DirFS("./dist")))
 	} else {
 		webFS = http.FileServer(http.FS(web.assets))
 	}

web/static_test.go

@@ -314,3 +314,58 @@ func TestRegisterRoutes(t *testing.T) {
 		assert.Equal(t, "console.log('Hello, world!');", recorder.Body.String(), "Response should contain the JS content")
 	})
 }
+func TestRegisterRoutesWithDevEnv(t *testing.T) {
+	// Create initial state
+	initialState := InitialState{
+		Title: "Test Title",
+		Icon:  "test-icon.png",
+	}
+
+	// Create a test logger
+	logger, _ := logtest.NewNullLogger()
+
+	// Create a new Web instance
+	web, err := New(initialState, WithLogger(logger), WithAssetsFS(createMockFS()))
+	require.NoError(t, err, "Failed to create Web instance")
+
+	// Create temporary dist directory structure for development
+	err = os.MkdirAll("dist/assets", 0755)
+	require.NoError(t, err, "Failed to create dist directory")
+	defer os.RemoveAll("dist/assets") // Clean up after test
+
+	// Create a test file in the dist/assets directory
+	devFileContent := "console.log('Development mode!');"
+	err = os.WriteFile("dist/assets/test-file-dev-app.js", []byte(devFileContent), 0644)
+	require.NoError(t, err, "Failed to write dev file")
+
+	// Set the development environment variable
+	t.Setenv("EC_DEV_ENV", "true")
+	// Create router and register routes
+	router := mux.NewRouter()
+	web.RegisterRoutes(router)
+
+	t.Run("Dev File from Local Filesystem", func(t *testing.T) {
+		req := httptest.NewRequest("GET", "/assets/test-file-dev-app.js", nil)
+		recorder := httptest.NewRecorder()
+
+		// Serve the request
+		router.ServeHTTP(recorder, req)
+
+		// Check status code
+		assert.Equal(t, http.StatusOK, recorder.Code, "Should return status OK for dev file")
+
+		// Check that the dev file content is served from local filesystem
+		assert.Equal(t, devFileContent, recorder.Body.String(), "Response should contain the dev file content from local filesystem")
+	})
+
+	t.Run("Non-existent File Returns 404", func(t *testing.T) {
+		req := httptest.NewRequest("GET", "/assets/non-existent.js", nil)
+		recorder := httptest.NewRecorder()
+
+		// Serve the request
+		router.ServeHTTP(recorder, req)
+
+		// Check status code - should be 404 when file doesn't exist in local filesystem
+		assert.Equal(t, http.StatusNotFound, recorder.Code, "Should return 404 for non-existent file in dev mode")
+	})
+}