Skip to content

Commit 957b9a4

Browse files
devin-ai-integration[bot]TomTom
andauthored
Fix connectorImages examples to use RDNS format (#453)
* Fix connectorImages examples to use RDNS format - Replace 'metaMask' with 'io.metamask' - Replace 'coinbaseWallet' with 'io.coinbase' - Replace 'phantom' with 'app.phantom' - Keep 'walletConnect' and 'appKitAuth' as-is (no RDNS found) Updates examples in shared options and React Native documentation to match actual AppKit implementation requirements. Co-Authored-By: TomTom <tomtom@reown.com> * Update connectorImages documentation to support both RDNS and normal IDs - Add explanatory text about dual approach for connector identification - EIP6963 wallets use RDNS format (io.metamask, io.coinbase, app.phantom) - Other wallets use normal connector IDs (walletConnect, injected, appKitAuth) - Update all examples across Wagmi, Ethers, and Solana adapters - Address reviewer feedback from svenvoskamp on PR #453 Co-Authored-By: TomTom <tomtom@reown.com> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: TomTom <tomtom@reown.com>
1 parent 7bd72b0 commit 957b9a4

File tree

2 files changed

+19
-7
lines changed

2 files changed

+19
-7
lines changed

appkit/react-native/core/options.mdx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,9 @@ Set or override the images of any connector.
254254
```ts
255255
createAppKit({
256256
connectorImages: {
257-
coinbaseWallet: "https://images.mydapp.com/coinbase.png",
257+
// EIP6963 wallets (announced wallets use RDNS)
258+
'io.coinbase': "https://images.mydapp.com/coinbase.png",
259+
// Other wallets (use normal connector IDs)
258260
walletConnect: "https://images.mydapp.com/walletconnect.png",
259261
appKitAuth: "https://images.mydapp.com/auth.png",
260262
},

snippets/appkit/shared/options.mdx

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -147,13 +147,19 @@ createAppKit({
147147
<Tabs>
148148
<Tab title="Wagmi">
149149

150-
Set or override the images of any [connector](https://wagmi.sh/core/connectors/injected). The key of each property must match the id of the connector.
150+
Set or override the images of any [connector](https://wagmi.sh/core/connectors/injected). AppKit supports two types of connector identification:
151+
- **EIP6963 wallets** (announced wallets): Use RDNS format like `'io.metamask'`, `'io.coinbase'`, `'app.phantom'`
152+
- **Other wallets**: Use normal connector IDs like `walletConnect`, `injected`, `appKitAuth`
151153

152154
```ts
153155
createAppKit({
154156
connectorImages: {
155-
coinbaseWallet: "https://images.mydapp.com/coinbase.png",
156-
metaMask: "https://images.mydapp.com/metamask.png",
157+
// EIP6963 wallets (announced wallets use RDNS)
158+
'io.coinbase': "https://images.mydapp.com/coinbase.png",
159+
'io.metamask': "https://images.mydapp.com/metamask.png",
160+
// Other wallets (use normal connector IDs)
161+
walletConnect: "https://images.mydapp.com/walletconnect.png",
162+
injected: "https://images.mydapp.com/browser-wallet.png",
157163
},
158164
});
159165
```
@@ -166,7 +172,9 @@ Set or override the images of any connector.
166172
```ts
167173
createAppKit({
168174
connectorImages: {
169-
coinbaseWallet: "https://images.mydapp.com/coinbase.png",
175+
// EIP6963 wallets (announced wallets use RDNS)
176+
'io.coinbase': "https://images.mydapp.com/coinbase.png",
177+
// Other wallets (use normal connector IDs)
170178
walletConnect: "https://images.mydapp.com/walletconnect.png",
171179
},
172180
});
@@ -180,8 +188,10 @@ Set or override the images of any connector.
180188
```ts
181189
createAppKit({
182190
connectorImages: {
183-
coinbaseWallet: "https://images.mydapp.com/coinbase.png",
184-
phantom: "https://images.mydapp.com/phantom.png",
191+
// EIP6963 wallets (announced wallets use RDNS)
192+
'io.coinbase': "https://images.mydapp.com/coinbase.png",
193+
'app.phantom': "https://images.mydapp.com/phantom.png",
194+
// Other wallets (use normal connector IDs)
185195
walletConnect: "https://images.mydapp.com/walletconnect.png",
186196
},
187197
});

0 commit comments

Comments
 (0)