Skip to content

Commit c28fcb9

Browse files
chore: wrapped authview in memo (#285)
* chore: wrapped authview in memo
1 parent 007909c commit c28fcb9

File tree

4 files changed

+6
-36
lines changed

4 files changed

+6
-36
lines changed

.github/workflows/verify.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,3 @@ jobs:
2424

2525
- name: Package Tests
2626
run: yarn test
27-
28-
- name: E2E Tests
29-
uses: ./.github/workflows/e2e.yml
30-
with:
31-
skip_setup: true # Skip redundant setup steps
32-
secrets: inherit

apps/native/.github/workflows/playwright.yml

Lines changed: 0 additions & 27 deletions
This file was deleted.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
"clean": "turbo clean && rm -rf node_modules && watchman watch-del-all",
3333
"format": "prettier --write \"**/*.{ts,tsx,js,jsx,json,md}\" --ignore-path .gitignore",
3434
"changeset:prepublish": "yarn run clean; yarn install; yarn version:update; yarn run lint && yarn run prettier; yarn run build; yarn run test;",
35-
"changeset:publish": "yarn run changeset:prepublish; yarn run changeset publish",
35+
"changeset:publish": "yarn run changeset:prepublish; yarn run changeset publish --no-git-tag",
3636
"changeset:version": "changeset version; yarn run version:update; yarn install --refresh-lockfile",
3737
"version:update": "./scripts/bump-version.sh"
3838
},

packages/wallet/src/AppKitAuthWebview.tsx

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { useSnapshot } from 'valtio';
2-
import { useEffect, useRef, useState } from 'react';
2+
import { memo, useEffect, useRef, useState } from 'react';
33
import { Animated, Appearance, Linking, Platform, SafeAreaView, StyleSheet } from 'react-native';
44
import { WebView, type WebViewMessageEvent } from 'react-native-webview';
55

@@ -24,7 +24,7 @@ import type { AppKitFrameTypes } from './AppKitFrameTypes';
2424

2525
const AnimatedSafeAreaView = Animated.createAnimatedComponent(SafeAreaView);
2626

27-
export function AuthWebview() {
27+
function _AuthWebview() {
2828
const webviewRef = useRef<WebView>(null);
2929
const Theme = useTheme();
3030
const authConnector = ConnectorController.getAuthConnector();
@@ -176,6 +176,7 @@ export function AuthWebview() {
176176
containerStyle={styles.webview}
177177
injectedJavaScript={AppKitFrameConstants.FRAME_MESSAGES_HANDLER}
178178
ref={webviewRef}
179+
webviewDebuggingEnabled
179180
onOpenWindow={syntheticEvent => {
180181
const { nativeEvent } = syntheticEvent;
181182
const { targetUrl } = nativeEvent;
@@ -217,6 +218,8 @@ export function AuthWebview() {
217218
) : null;
218219
}
219220

221+
export const AuthWebview = memo(_AuthWebview);
222+
220223
const styles = StyleSheet.create({
221224
backdrop: {
222225
position: 'absolute',

0 commit comments

Comments
 (0)