chore: code improvements

Author: ignaciosantise

packages/core/src/controllers/SwapController.ts

@@ -718,7 +718,7 @@ export const SwapController = {
       const error = err as TransactionError;
       state.transactionError = error?.shortMessage as unknown as string;
       state.loadingApprovalTransaction = false;
-      SnackController.showError(error?.shortMessage || 'Transaction error');
+      SnackController.showError(error?.shortMessage ?? 'Transaction error');
     }
   },
 
@@ -795,12 +795,12 @@ export const SwapController = {
       const error = err as TransactionError;
       state.transactionError = error?.shortMessage;
       state.loadingTransaction = false;
-      SnackController.showError(error?.shortMessage || 'Transaction error');
+      SnackController.showError(error?.shortMessage ?? 'Transaction error');
       EventsController.sendEvent({
         type: 'track',
         event: 'SWAP_ERROR',
         properties: {
-          message: error?.shortMessage || error?.message || 'Unknown',
+          message: error?.shortMessage ?? error?.message ?? 'Unknown',
           network: NetworkController.state.caipNetwork?.id || '',
           swapFromToken: this.state.sourceToken?.symbol || '',
           swapToToken: this.state.toToken?.symbol || '',

packages/core/src/utils/SwapCalculationUtil.ts

@@ -63,7 +63,7 @@ export const SwapCalculationUtil = {
   },
 
   isInsufficientNetworkTokenForGas(networkBalanceInUSD: string, gasPriceInUSD: number | undefined) {
-    const gasPrice = gasPriceInUSD || '0';
+    const gasPrice = gasPriceInUSD ?? '0';
 
     if (NumberUtil.bigNumber(networkBalanceInUSD).isZero()) {
       return true;
@@ -80,7 +80,7 @@ export const SwapCalculationUtil = {
     const sourceTokenBalance = balance?.find(token => token.address === sourceTokenAddress)
       ?.quantity?.numeric;
 
-    const isInSufficientBalance = NumberUtil.bigNumber(sourceTokenBalance || '0').isLessThan(
+    const isInSufficientBalance = NumberUtil.bigNumber(sourceTokenBalance ?? '0').isLessThan(
       sourceTokenAmount
     );
 

packages/core/src/utils/TypeUtil.ts

@@ -654,7 +654,7 @@ export type Event =
 
 // -- Send Controller Types -------------------------------------
 export type EstimateGasTransactionArgs = {
-  chainNamespace?: undefined | 'eip155';
+  chainNamespace?: 'eip155';
   address: `0x${string}`;
   to: `0x${string}`;
   data: `0x${string}`;