Final fix for release asset

Author: renvins

.github/workflows/ci.yml

@@ -80,57 +80,4 @@ jobs:
         if: always()
         run: |
           echo "Stopping Docker containers..."
-          docker compose -f infra/docker-compose.yml down -v # -v removes volumes too
-  create-release:
-    needs: build-and-test-infra
-    if: startsWith(github.ref, 'refs/tags/')
-    runs-on: ubuntu-latest
-    permissions:
-      contents: write # Needed to create releases and upload assets
-
-    steps:
-      # 1. Checkout Repository code - Needed to access build files/scripts
-      - name: Checkout Repository
-        uses: actions/checkout@v4
-
-      # 2. Set up JDK (Must match the version used for building)
-      - name: Set up JDK 21
-        uses: actions/setup-java@v4
-        with:
-          java-version: '21'
-          distribution: 'temurin'
-
-      # 3. Grant permissions to gradle to execute commands
-      - name: Grant execute permission for gradlew
-        run: chmod +x gradlew
-        
-      # Setup Gradle and Build the Shadow Jar
-      - name: Setup Gradle and Build Shadow Jar
-        uses: gradle/actions/setup-gradle@v4
-
-      # Build the jar
-      - name: Build jar
-        run: ./gradlew shadowJar
-
-      # 4. Find the specific Shadow Jar file
-      # Adjust the pattern if your shadowJar output has a different name convention
-      - name: Find Shadow Jar
-        id: find_jar
-        run: |
-          # Common patterns: *-all.jar, *-shadow.jar, or just your plugin name + version.jar
-          # This finds the largest JAR in build/libs, usually the shadowJar
-          JAR_FILE=$(find plugin/build/libs -maxdepth 1 -name '*.jar' -printf "%s %p\n" | sort -nr | head -n 1 | awk '{print $2}')
-          if [ -z "$JAR_FILE" ]; then
-            echo "Error: Could not find the shadow JAR file in plugin/build/libs/"
-            exit 1
-          fi
-          echo "Found JAR for release: $JAR_FILE"
-          echo "path=$JAR_FILE" >> $GITHUB_OUTPUT
-
-      # 5. Create GitHub Release and Upload the Shadow Jar
-      - name: Create Release and Upload JAR
-        uses: softprops/action-gh-release@v2
-        with:
-          name: Release ${{ github.ref_name }}
-          draft: true
-          files: ${{ steps.find_jar.outputs.path }} # Upload the specific JAR found earlier
+          docker compose -f infra/docker-compose.yml down -v # -v removes volumes too

.github/workflows/create_release.yml

@@ -0,0 +1,63 @@
+name: Create Release Asset
+
+# Trigger the workflow only when a release is published
+on:
+  release:
+    types: [published] # Only run when a release goes from draft/pre-release to published, or is created as published
+
+permissions:
+  contents: write # Allow workflow to write release assets
+
+jobs:
+  build-and-upload:
+    runs-on: ubuntu-latest
+    steps:
+      # 1. Checkout Repository code
+      - name: Checkout code at release tag
+        uses: actions/checkout@v4
+
+      # 2. Set up JDK (Must match the version used for building)
+      - name: Set up JDK 21
+        uses: actions/setup-java@v4
+        with:
+          java-version: '21'
+          distribution: 'temurin'
+
+      # 3. Give permission to gradle to execute commands
+      - name: Grant execute permission for gradlew
+        run: chmod +x gradlew
+
+      # Setup Gradle - This action handles caching and executing gradle tasks
+      # It automatically finds and uses ./gradlew
+      - name: Setup Gradle and Build Plugin Jar
+        uses: gradle/actions/setup-gradle@v4 # Use v4 or latest stable version
+
+      # Gradle with the new updates doesn't support arguments
+      - name: Build jar
+        run: ./gradlew shadowJar
+
+      # 5. Find the specific Shadow Jar file and extract its name
+      - name: Find Shadow Jar and Extract Name
+        id: find_jar
+        run: |
+          JAR_PATH=$(find plugin/build/libs -maxdepth 1 -name '*.jar' -printf "%s %p\n" | sort -nr | head -n 1 | awk '{print $2}')
+          if [ -z "$JAR_PATH" ]; then
+            echo "Error: Could not find the shadow JAR file in plugin/build/libs/"
+            exit 1
+          fi
+          JAR_FILENAME=$(basename "$JAR_PATH")
+          echo "Found JAR path: $JAR_PATH"
+          echo "Found JAR filename: $JAR_FILENAME"
+          echo "path=$JAR_PATH" >> $GITHUB_OUTPUT
+          echo "filename=$JAR_FILENAME" >> $GITHUB_OUTPUT
+        shell: bash
+
+      # 6. Upload the Shadow Jar as a release asset
+      - name: Upload Release Asset
+        uses: svenstaro/upload-release-action@v2
+        with:
+          repo_token: ${{ secrets.GITHUB_TOKEN }} # Provided by GitHub Actions automatically
+          file: ${{ steps.find_jar.outputs.path }} # The path to the JAR found in the previous step
+          asset_name: ${{ steps.find_jar.outputs.filename }} # Use the filename extracted earlier
+          tag: ${{ github.ref }} # The git tag associated with the release that triggered the workflow
+          overwrite: true # Optional: Replace asset with the same name if it already exists