Skip to content

Commit b5aa3cd

Browse files
committed
Remove metrics.enabled check from configuration
1 parent f006e84 commit b5aa3cd

File tree

4 files changed

+7
-17
lines changed

4 files changed

+7
-17
lines changed

bukkit/src/main/java/it/renvins/serverpulse/bukkit/ServerPulseBukkitLoader.java

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@
2525
import it.renvins.serverpulse.bukkit.platform.BukkitPlatform;
2626
import it.renvins.serverpulse.bukkit.scheduler.BukkitTaskScheduler;
2727
import it.renvins.serverpulse.common.MetricsService;
28+
import it.renvins.serverpulse.common.platform.Platform;
29+
import it.renvins.serverpulse.common.scheduler.TaskScheduler;
2830

2931
public class ServerPulseBukkitLoader implements Service {
3032

@@ -33,6 +35,8 @@ public class ServerPulseBukkitLoader implements Service {
3335

3436
private final BukkitConfiguration config;
3537

38+
private final Platform platform;
39+
3640
private final IDatabaseService databaseService;
3741
private final IMetricsService metricsService;
3842

@@ -48,8 +52,8 @@ public ServerPulseBukkitLoader(ServerPulseBukkit plugin) {
4852

4953
PulseLogger logger = new BukkitLogger(LOGGER);
5054

51-
BukkitPlatform platform = new BukkitPlatform(plugin);
52-
BukkitTaskScheduler taskScheduler = new BukkitTaskScheduler(plugin);
55+
this.platform = new BukkitPlatform(plugin);
56+
TaskScheduler taskScheduler = new BukkitTaskScheduler(plugin);
5357

5458
DatabaseConfiguration databaseConfiguration = new BukkitDatabaseConfiguration(config);
5559
MetricsConfiguration metricsConfiguration = new BukkitMetricsConfiguration(config);
@@ -71,16 +75,10 @@ public void load() {
7175
LOGGER.info("Loading configuration...");
7276
config.load();
7377

74-
if(!config.getConfig().getBoolean("metrics.enabled")) {
75-
LOGGER.severe("Shutting down the plugin because metrics are disabled!");
76-
plugin.getServer().getPluginManager().disablePlugin(plugin);
77-
78-
return;
79-
}
8078
ServerPulseProvider.register(new ServerPulseBukkitAPI(databaseService, metricsService, tpsRetriever, diskRetriever, pingRetriever));
8179

8280
databaseService.load();
83-
if (!plugin.isEnabled()) {
81+
if (!platform.isEnabled()) {
8482
return;
8583
}
8684
metricsService.load();

bukkit/src/main/resources/config.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
metrics:
2-
enabled: true
32
interval: 5
43
influxdb:
54
url: http://localhost:8086 # The URL of the InfluxDB API

velocity/src/main/java/it/renvins/serverpulse/velocity/ServerPulseVelocity.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -64,12 +64,6 @@ public void onProxyInitialization(ProxyInitializeEvent event) {
6464
logger.info("Loading configuration file...");
6565
config.load();
6666

67-
if(!config.getConfig().getBoolean("metrics.enabled")) {
68-
logger.error("Shutting down the plugin because metrics are disabled!");
69-
server.shutdown();
70-
71-
return;
72-
}
7367
DatabaseConfiguration dbConfig = new VelocityDatabaseConfiguration(config);
7468
MetricsConfiguration metricsConfig = new VelocityMetricsConfiguration(config);
7569

velocity/src/main/resources/config.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
metrics:
2-
enabled: true
32
interval: 5
43
influxdb:
54
url: http://localhost:8086 # The URL of the InfluxDB API

0 commit comments

Comments
 (0)