Rename PingRetriever to BukkitPingRetriever, add VelocityPingRetriever and VelocityTPSRetriever implementations, and enhance ITPSRetriever with default method

Author: renvins

api/src/main/java/it/renvins/serverpulse/api/metrics/ITPSRetriever.java

@@ -2,5 +2,16 @@
 
 public interface ITPSRetriever {
 
-    double[] getTPS();
+    /**
+     * Retrieves the TPS (Ticks Per Second) of the server.
+     *
+     * @return an array of doubles representing the TPS values.
+     *         The first value is the average TPS over the last minute,
+     *         the second value is the average TPS over the last 5 minutes,
+     *         and the third value is the average TPS over the last 15 minutes.
+     * @throws UnsupportedOperationException if the platform does not support this operation.
+     */
+    default double[] getTPS() {
+        throw new UnsupportedOperationException("This method is not supported on this platform.");
+    }
 }

bukkit/src/main/java/it/renvins/serverpulse/bukkit/ServerPulseBukkitLoader.java

@@ -18,7 +18,7 @@
 import it.renvins.serverpulse.common.metrics.DiskRetriever;
 import it.renvins.serverpulse.bukkit.config.BukkitDatabaseConfiguration;
 import it.renvins.serverpulse.bukkit.config.BukkitMetricsConfiguration;
-import it.renvins.serverpulse.bukkit.metrics.PingRetriever;
+import it.renvins.serverpulse.bukkit.metrics.BukkitPingRetriever;
 import it.renvins.serverpulse.bukkit.metrics.PaperTPSRetriever;
 import it.renvins.serverpulse.bukkit.platform.BukkitPlatform;
 import it.renvins.serverpulse.bukkit.scheduler.BukkitTaskScheduler;
@@ -62,7 +62,7 @@ public ServerPulseBukkitLoader(ServerPulseBukkit plugin) {
             this.tpsRetriever = new BukkitTPSRetriever(plugin);
         }
         this.diskRetriever = new DiskRetriever(plugin.getDataFolder());
-        this.pingRetriever = new PingRetriever();
+        this.pingRetriever = new BukkitPingRetriever();
     }
 
     @Override

bukkit/src/main/java/it/renvins/serverpulse/bukkit/metrics/PingRetriever.java renamed to bukkit/src/main/java/it/renvins/serverpulse/bukkit/metrics/BukkitPingRetriever.java

@@ -4,7 +4,7 @@
 import org.bukkit.Bukkit;
 import org.bukkit.entity.Player;
 
-public class PingRetriever implements IPingRetriever {
+public class BukkitPingRetriever implements IPingRetriever {
 
     @Override
     public int getMinPing() {

common/src/main/java/it/renvins/serverpulse/common/MetricsService.java

@@ -100,11 +100,12 @@ private SyncMetricsSnapshot collectSnapshot() {
             throw new IllegalStateException("This method must be called on the main thread.");
         }
         try {
-            double[] tps = ServerPulseProvider.get().getTPSRetriever().getTPS();
+            double[] tps = new double[]{0.0, 0.0, 0.0}; // Default TPS to 0.0 for non-ticking platforms
             int playerCount = platform.getOnlinePlayerCount();
 
             Map<String, WorldData> worldsData = null;
             try {
+                tps = ServerPulseProvider.get().getTPSRetriever().getTPS();
                 worldsData = platform.getWorldsData();
             } catch (UnsupportedOperationException e) {
                 worldsData = Map.of();

velocity/src/main/java/it/renvins/serverpulse/velocity/ServerPulseVelocity.java

@@ -1,13 +1,19 @@
 package it.renvins.serverpulse.velocity;
 
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+
 import com.google.common.eventbus.Subscribe;
 import com.google.inject.Inject;
 import com.velocitypowered.api.plugin.Plugin;
+import com.velocitypowered.api.plugin.annotation.DataDirectory;
 import com.velocitypowered.api.proxy.ProxyServer;
 import it.renvins.serverpulse.api.service.IDatabaseService;
 import it.renvins.serverpulse.api.service.IMetricsService;
 import it.renvins.serverpulse.common.DatabaseService;
 import it.renvins.serverpulse.common.MetricsService;
+import it.renvins.serverpulse.common.config.DatabaseConfiguration;
 import lombok.Getter;
 import org.slf4j.Logger;
 
@@ -17,19 +23,24 @@ public class ServerPulseVelocity {
 
     @Getter private final ProxyServer server;
     private final Logger logger;
+    private final Path dataDirectory;
 
     private IDatabaseService databaseService;
     private IMetricsService metricsService;
 
     @Inject
-    public ServerPulseVelocity(ProxyServer server, Logger logger) {
+    public ServerPulseVelocity(ProxyServer server, Logger logger, @DataDirectory Path dataDirectory) {
         this.server = server;
         this.logger = logger;
+        this.dataDirectory = dataDirectory;
     }
 
     @Subscribe
     public void onProxyInitialization() {
         this.databaseService = new DatabaseService();
         this.metricsService = new MetricsService();
     }
+
+    private void loadConfig() {
+    }
 }

velocity/src/main/java/it/renvins/serverpulse/velocity/metrics/VelocityPingRetriever.java

@@ -0,0 +1,50 @@
+package it.renvins.serverpulse.velocity.metrics;
+
+import com.velocitypowered.api.proxy.Player;
+import it.renvins.serverpulse.api.metrics.IPingRetriever;
+import it.renvins.serverpulse.velocity.ServerPulseVelocity;
+import lombok.RequiredArgsConstructor;
+
+@RequiredArgsConstructor
+public class VelocityPingRetriever implements IPingRetriever {
+
+    private final ServerPulseVelocity plugin;
+
+    @Override
+    public int getMinPing() {
+        int minPing = Integer.MAX_VALUE;
+        if (plugin.getServer().getAllPlayers().isEmpty()) {
+            return 0;
+        }
+        for (Player player : plugin.getServer().getAllPlayers()) {
+            minPing = Math.toIntExact(Math.min(minPing, player.getPing()));
+        }
+        return minPing;
+    }
+
+    @Override
+    public int getMaxPing() {
+        int maxPing = 0;
+        if (plugin.getServer().getAllPlayers().isEmpty()) {
+            return 0;
+        }
+        for (Player player : plugin.getServer().getAllPlayers()) {
+            maxPing = Math.toIntExact(Math.max(maxPing, player.getPing()));
+        }
+        return maxPing;
+    }
+
+    @Override
+    public int getAveragePing() {
+        int totalPing = 0;
+        int playerCount = plugin.getServer().getAllPlayers().size();
+        if (playerCount == 0) {
+            return 0;
+        }
+        for (Player player : plugin.getServer().getAllPlayers()) {
+            totalPing += (int) player.getPing();
+        }
+        return totalPing / playerCount;
+    }
+}
+

velocity/src/main/java/it/renvins/serverpulse/velocity/metrics/VelocityTPSRetriever.java

@@ -0,0 +1,5 @@
+package it.renvins.serverpulse.velocity.metrics;
+
+import it.renvins.serverpulse.api.metrics.ITPSRetriever;
+
+public class VelocityTPSRetriever implements ITPSRetriever {}