Minor code quality improvements

Author: duckdoom4

src/decorator.ts

@@ -1,5 +1,5 @@
 import { ConfigurationTarget, workspace } from "vscode";
-import util = require("util");
+import * as util from "util";
 import { IEquatable, ValueEqualsSet } from "./utilities/hashset";
 import { LogLevel, logMessage } from "./logger";
 

src/hover.ts

@@ -192,30 +192,32 @@ export function getDefinitionFromFile(filename: string, line: number): Navigatio
     try {
         const data = fs.readFileSync(filepath, "utf-8");
         const lines = data.split("\n");
-        if (line <= lines.length) {
-            let text = lines[line - 1].trim();
-            if (text.endsWith(":")) {
-                text = text.slice(0, -1);
-            } else if (text.endsWith("(")) {
-                text = text + ")";
-            } else if (text.endsWith("[")) {
-                text = text + "]";
-            } else if (text.endsWith("{")) {
-                text = text + "}";
-            }
+        if (line >= lines.length) {
+            return undefined;
+        }
 
-            let docs = "";
-            docs = getPyDocsAtLine(lines, line - 1);
+        let text = lines[line - 1].trim();
+        if (text.endsWith(":")) {
+            text = text.slice(0, -1);
+        } else if (text.endsWith("(")) {
+            text = text + ")";
+        } else if (text.endsWith("[")) {
+            text = text + "]";
+        } else if (text.endsWith("{")) {
+            text = text + "}";
+        }
 
-            let args = "";
-            if (text.indexOf("(") > 0) {
-                args = text.substring(text.indexOf("("));
-                args = args.replace("(self, ", "(");
-                args = args.replace("(self)", "()");
-            }
+        let docs = "";
+        docs = getPyDocsAtLine(lines, line - 1);
 
-            return new Navigation("workspace", text, filename, line, docs, args, "", 0);
+        let args = "";
+        if (text.indexOf("(") > 0) {
+            args = text.substring(text.indexOf("("));
+            args = args.replace("(self, ", "(");
+            args = args.replace("(self)", "()");
         }
+
+        return new Navigation("workspace", text, filename, line, docs, args, "", 0);
     } catch (error) {
         return undefined;
     }

src/navigation-data.ts

@@ -201,13 +201,16 @@ export class NavigationData {
         if (locations && locations.length > 0) {
             return locations;
         }
+
+        return undefined;
     }
 
     static getNavigationDumpEntry(keyword: string): Navigation | undefined {
         const data = NavigationData.getNavigationDumpEntries(keyword);
         if (data) {
             return data[0];
         }
+        return undefined;
     }
 
     static getNavigationDumpEntries(keyword: string): Navigation[] | undefined {
@@ -416,6 +419,7 @@ export class NavigationData {
                 }
             }
         }
+        return;
     }
 
     static getClassData(location: Navigation): Navigation {

src/utilities/hashset.ts

@@ -12,7 +12,7 @@ export interface IEquatable<T> {
  * The current implementation is not very efficient, but it works.
  */
 export class ValueEqualsSet<T extends IEquatable<T>> extends Set<T> {
-    add(value: T) {
+    override add(value: T) {
         if (!this.has(value)) {
             super.add(value);
         }
@@ -26,7 +26,7 @@ export class ValueEqualsSet<T extends IEquatable<T>> extends Set<T> {
         return this;
     }
 
-    has(otherValue: T): boolean {
+    override has(otherValue: T): boolean {
         for (const value of this.values()) {
             if (value.equals(otherValue)) {
                 return true;

tsconfig.json

@@ -23,10 +23,12 @@
     /* Additional Checks */
     "noUnusedLocals": true, // Report errors on unused locals.
     // "noUnusedParameters": true, // Report errors on unused parameters.
-    //"noImplicitReturns": true, // Report error when not all code paths in function return a value.
     // "noFallthroughCasesInSwitch": true, // Report errors for fallthrough cases in switch statement.
     // "noUncheckedIndexedAccess": true, // Include 'undefined' in index signature results
     // "noPropertyAccessFromIndexSignature": true, // Require undeclared properties from index signatures to use element accesses.
+    "noImplicitReturns": true, // Report error when not all code paths in function return a value.
+    "noImplicitOverride": true, // Ensure overriding members in derived classes are marked with an 'override' modifier.
+    "noImplicitThis": true, // Raise error on 'this' expressions with an implied 'any' type.
     "exactOptionalPropertyTypes": true, // Force exact optional types. (Aka. undefined needs to be added to optionals)
 
     /* Module Resolution Options */