Change order of PR title/description update to be after updating the commit

[simonhaenisch]

I've observed a weird behavior yesterday on our Github Enterprise where a PR's title and description were updated after the user ticked the "rebase/retry" checkbox, however the changes in the commit didn't match, and in fact I couldn't see any new commit being force-pushed. Looking into the debug logs, it turned out that it failed to rebase the PR because of a misconfigured ruleset that rejected the push.

I'm just wondering whether it would make sense to switch the order here, i.e. first update the branch, then update the PR's title/description, since the latter seems much less likely to fail?

edit: i might understand now that updating the PR description first makes sense from the point that otherwise the checkbox would still be ticked. I guess it could update the description once to untick the box, then update the commit, then update the title/description. Anyway, a comment like "failed to update the PR" might be useful in case the force-push failed?