Some errors compiling in Arduino IDE 2.3.4

[mr-sneezy]

Hi all,
I'm only a code hack part time so don't have much debugging skill. Having a bunch of errors doing a base compile (no changes to headers) using Arduino 2.3.4 and the current version libraries. I'd like to use the IDE 2 of Arduino if possible as I use it for other small projects.
The errors I'm seeing are related to BLE or BT

Any pointers on what the issue is are welcomed.

D:\Documents\Arduino\bonogps\bonogps.ino: In function 'void handle_hlt()':
D:\Documents\Arduino\bonogps\bonogps.ino:1819:7: error: 'ble_start' was not declared in this scope; did you mean 'va_start'?
1819 | ble_start();
| ^~~~~~~~~
| va_start
D:\Documents\Arduino\bonogps\bonogps.ino: In function 'bool bt_spp_stop()':
D:\Documents\Arduino\bonogps\bonogps.ino:2549:7: error: 'esp_bt_controller_get_status' was not declared in this scope
2549 | if (esp_bt_controller_get_status() == ESP_BT_CONTROLLER_STATUS_IDLE)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
D:\Documents\Arduino\bonogps\bonogps.ino:2549:41: error: 'ESP_BT_CONTROLLER_STATUS_IDLE' was not declared in this scope
2549 | if (esp_bt_controller_get_status() == ESP_BT_CONTROLLER_STATUS_IDLE)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
D:\Documents\Arduino\bonogps\bonogps.ino:2554:7: error: 'esp_bt_controller_get_status' was not declared in this scope
2554 | if (esp_bt_controller_get_status() == ESP_BT_CONTROLLER_STATUS_ENABLED)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
D:\Documents\Arduino\bonogps\bonogps.ino:2554:41: error: 'ESP_BT_CONTROLLER_STATUS_ENABLED' was not declared in this scope
2554 | if (esp_bt_controller_get_status() == ESP_BT_CONTROLLER_STATUS_ENABLED)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
D:\Documents\Arduino\bonogps\bonogps.ino:2557:9: error: 'esp_bt_controller_disable' was not declared in this scope
2557 | if (esp_bt_controller_disable())
| ^~~~~~~~~~~~~~~~~~~~~~~~~
D:\Documents\Arduino\bonogps\bonogps.ino:2565:7: error: 'esp_bt_controller_get_status' was not declared in this scope
2565 | if (esp_bt_controller_get_status() == ESP_BT_CONTROLLER_STATUS_INITED)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
D:\Documents\Arduino\bonogps\bonogps.ino:2565:41: error: 'ESP_BT_CONTROLLER_STATUS_INITED' was not declared in this scope
2565 | if (esp_bt_controller_get_status() == ESP_BT_CONTROLLER_STATUS_INITED)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
D:\Documents\Arduino\bonogps\bonogps.ino:2568:9: error: 'esp_bt_controller_deinit' was not declared in this scope
2568 | if (esp_bt_controller_deinit())
| ^~~~~~~~~~~~~~~~~~~~~~~~
Multiple libraries were found for "BluetoothSerial.h"
Used: C:\Users\mrdot\AppData\Local\Arduino15\packages\esp32\hardware\esp32\3.1.1\libraries\BluetoothSerial
Not used: D:\Arduino\libraries\BluetoothSerial
exit status 1

Compilation error: 'ble_start' was not declared in this scope; did you mean 'va_start'?

[renatobo]

Hello there
Have you followed the IDE steps guide?

The BLE libraries have a new version 2.0 that has not tested yet, and the last time code I compiled code it was the Arduino IDE 1.8: I would start using version 1.4.3 of NimBLE

[mr-sneezy]

Thanks for responding :)
Yes I did carefully follow the six dot points in your guide. I'll try the NimBLE 1.4.3. and see what happens.

[mr-sneezy]

Some tests with NimBLE 1.4.3 installed.
Compile passes when BLEENABLED enabled and BTSPPENABLED is disabled.
Compile fails with errors as above when BTSPPENABLED enabled and BLEENABLED is disabled.

My use case needs BTSPP...

I then installed NimBLE 2.2.1 to test that version for the difference. With this version BLEENABLED fails to compile. Seems like the version of NimBLE does matter, but even with the older 1.4.3 BTSPP does not compile.
If you need the error messages from a particular compile attempt let me know?
I'm still using IDE V2.3.4

[micooke]

@renatobo - first up, great project! Been looking for something like this for ages!
@mr-sneezy - I was having the same issue. I did need v1.4.3 of NimBLE, but the errors you have above aren't actually related to that (read on).

@renatobo - Im not sure if this is of interest, but with a little modification to the cpp file to allow relative includes for Arduino, an empty .ino in the base dir will compile; tested in Arduino 1.8.15 and Arduino 2.3.4.
e.g.

#if __has_include("bonogps_board_settings.h")
#include "bonogps_board_settings.h"
#elif __has_include("include/bonogps_board_settings.h")
#include "include/bonogps_board_settings.h"
#endif

This is needed for the 3 include/ headers i.e. bonogps_board_settings.h, bonogps_css_base.h, bonogps_css_base_battery.

This approach supports both Arduino and PlatformIO without renaming bonogps.cpp to bonogps.ino (note that the copy/paste as suggested will cause a linker error as src/bonogps.cpp is found by Arduino and compiled and linked).

The first error at #L1819 is caused as it is missing an #ifdef guard. Note that this is only apparent if you comment out #define BLEENABLED to e.g. save space (as I did).
e.g.

#ifdef BLEENABLED
  ble_start();
#endif

The other errors are because its missing a header include for esp_bt.h. I'm guessing PlatformIO has no problem finding it, but I included it just before the esp_wifi.h include here #L108.

When I tried to compile it with an older version of Arduino I had a syntax error with the register_callback call on #L2525. This ended up being an error in the platform library which was resolved in arduino-esp32 #PR9245. This fix should be in any version 3.0.0+ of the espressif32 BluetoothSerial library. However, I couldn't get it to work with PlatformIO as that looks to be stuck on BluetoothSerial 2.0.0 for some reason? According to arduino-esp32 issue 7675 the error should only be with 2.0.6 of that library, so not sure what is going on there. Particularly when I see that the required modification seems to have been applied to v2.0.17 which is what my PlatformIO is using, which should be the latest if I am reading this correctly. For example here. It looks like PlatformIO is pulling an incompatible esp32 platform for the arduino-espressif32 framework?
This is something that might need to be pinned in platformio.ini if I sort it out.
i.e. (note: this config is valid, but it doesn't compile)

platform = espressif32@3.0.0
platform_packages =
   framework-arduinoespressif32@3.20017.0

Arduino 2.3.4 pulls BluetoothSerial 3.1.1, so thats fine.

@renatobo - I'm happy to submit a PR for this (with the modifications mentioned) if that is of interest? Or just the Bluetooth fixes?

[mr-sneezy]

Hello micooke. I also successfully compiled tonight using your bonogps.cpp file from your forked BluetoothSerial_fix branch (using a blank.ino). Thought you'd want to know. I had BLE option disabled, SPP enabled. Used 91% program space.

[renatobo]

Great writeup @micooke and thank you for taking the time to document your solution.

I will need a few days to review a PR, but please submit one on the newly created branch version2. I have been meaning to update all libraries, and this is a good opportunity to incorporate these changes in build options.

While there will be no new features in v2, it changes too many libraries and IDE so a major release makes sense.

Thank you again everyone for the contributions

[micooke]

Can do, I'll try tomorrow.

[micooke]

Done. See PR#43

[renatobo]

Thank you @mr-sneezy for the prompt to get this going and @micooke for the quick turn around on the changes.
Version 1.4 incorporates all of these and a few improvements to source code readability and important fixes a couple of libraries to a specific major/minor version