Skip to content

Commit ead3ff9

Browse files
test: upgrade preact in devDependencies and fix tests
preact ^10.4.4 → ^10.5.7
1 parent d56944d commit ead3ff9

File tree

3 files changed

+26
-12
lines changed

3 files changed

+26
-12
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
"husky": "^4.2.5",
5252
"jest": "^26.0.1",
5353
"lint-staged": "^10.2.7",
54-
"preact": "^10.4.4",
54+
"preact": "^10.5.7",
5555
"prettier": "^2.0.5",
5656
"react": "^16",
5757
"react-dom": "^16",

test/dom-to-react.test.js

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -95,19 +95,27 @@ describe('DOM to React', () => {
9595
const Preact = require('preact');
9696

9797
it('converts with React (default)', () => {
98-
const html = data.html.single;
99-
const reactElement = domToReact(htmlToDOM(html));
98+
const reactElement = domToReact(htmlToDOM(data.html.single));
10099

101100
expect(React.isValidElement(reactElement)).toBe(true);
101+
expect(Preact.isValidElement(reactElement)).toBe(false);
102+
102103
expect(reactElement).toEqual(React.createElement('p', {}, 'foo'));
103104
});
104105

105106
it('converts with Preact instead of React', () => {
106-
const html = data.html.single;
107-
const preactElement = domToReact(htmlToDOM(html), { library: Preact });
107+
const parsedElement = domToReact(htmlToDOM(data.html.single), {
108+
library: Preact
109+
});
110+
const preactElement = Preact.createElement('p', {}, 'foo');
111+
112+
expect(React.isValidElement(parsedElement)).toBe(false);
113+
expect(Preact.isValidElement(parsedElement)).toBe(true);
108114

109-
expect(Preact.isValidElement(preactElement)).toBe(true);
110-
expect(preactElement).toEqual(Preact.createElement('p', {}, 'foo'));
115+
// remove `__v` key since it's causing test equality to fail
116+
delete parsedElement.__v;
117+
delete preactElement.__v;
118+
expect(parsedElement).toEqual(preactElement);
111119
});
112120
});
113121

test/html-to-react.test.js

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -168,13 +168,19 @@ describe('HTML to React', () => {
168168
});
169169

170170
describe('library', () => {
171+
const Preact = require('preact');
172+
171173
it('converts with Preact instead of React', () => {
172-
const Preact = require('preact');
173-
const html = data.html.single;
174-
const options = { library: Preact };
175-
const preactElement = parse(html, options);
174+
const parsedElement = parse(data.html.single, { library: Preact });
175+
const preactElement = Preact.createElement('p', {}, 'foo');
176+
177+
expect(React.isValidElement(parsedElement)).toBe(false);
178+
expect(Preact.isValidElement(parsedElement)).toBe(true);
176179

177-
expect(preactElement).toEqual(Preact.createElement('p', {}, 'foo'));
180+
// remove `__v` key since it's causing test equality to fail
181+
delete parsedElement.__v;
182+
delete preactElement.__v;
183+
expect(parsedElement).toEqual(preactElement);
178184
});
179185
});
180186

0 commit comments

Comments
 (0)