Download quota plugin

[michaelkershaw]

im trying to change the download quota so it doesnt go off the expiration date in the plugin but the expiry date of the account in the account section is this possible? ive been looking on wiki and i cant see anything there that gives me the code or prefix to do that

[michaelkershaw]

1. ive done this bit removed the expire date for that in the download quota then i want to make it so it goes to the account section in image 2
   

2

[rejetto]

you are doing it the hard way,
i think the easiest thing you can do is to just leave the plugin as it is, and configure a very high number of hours.
90000 hours is over 10 years. I don't think you need more than that.

when the account expires, it will stop working completely, and the quota won't matter anymore.

[michaelkershaw]

ive scrapped that and i went with this

I set it up like this: I gave the account a 500GB quota and added an expiration date. However, I won't be able to use the expiration date in the account section, as it would override the settings. Once the expiration date passes, or if the quota isn't fully used before the account expires, it will end.

[rejetto]

did you just add the "expire" field i see in your screenshot, or did you also program the necessary logic to make it work?

[michaelkershaw]

i just used chat gpt to make it work as intended

exports.version = 2.22
exports.apiRequired = 10.2 // api.i18n
exports.repo = "rejetto/download-quota"
exports.description = "Download quota, per-account (no expiration, no auto-refresh)"
exports.frontend_js = 'main.js'
exports.changelog = [
    { "version": 2.22, "message": "Removed quota expiration and ensured no auto-refresh when exhausted" },
    { "version": 2.21, "message": "Finnish translation" },
    { "version": 2.2, "message": "Now the error message can be translated" },
    { "version": 2.15, "message": "Compatibility with new HFS version" },
    { "version": 2.14, "message": "Error fixed" },
    { "version": 2.1, "message": "Compatibility with new HFS version" },
    { "version": 2, "message": "Decide quota on specific accounts" }
]

exports.config = {
    megabytes: { type: 'number', min: 1, defaultValue: 1000, sm: 6, helperText: "Default quota applied per-account. Anonymous users are not restricted." },
    perAccount: { 
        type: 'array', 
        fields: { 
            username: { type: 'username' },
            megabytes: { type: 'number', min: 1, defaultValue: 1000 },
            expire: { type: 'date', helperText: "Expiration date for the account" }
        },
        label: "Decide quota on specific accounts"
    },
}

exports.configDialog = {
    sx: { maxWidth: '30em' },
}

const PREFIX = 'dlQuota_'

exports.init = async api => {
    const { debounceAsync, formatBytes } = api.require('./misc')
    const { getCurrentUsername } = api.require('./auth')
    const { join } = api.require('path')
    const { writeFile, readFile } = api.require('fs/promises')
    const _ = api.require('lodash')
    const perAccountFile = join(api.storageDir, 'per-account.json')
    let perAccount = {}

    // Load previous stats with error handling for empty or invalid JSON
    try {
        const fileData = await readFile(perAccountFile, 'utf8')
        if (fileData) {
            perAccount = JSON.parse(fileData) // Only parse if file is not empty
        }
    } catch (err) {
        if (err.code !== 'ENOENT') {
            api.log('Error reading per-account.json:', err) // Log the error if it's not "file not found"
        }
        // Fallback: initialize an empty object if parsing fails or file is empty
        perAccount = {}
    }

    const save = debounceAsync(() => writeFile(perAccountFile, JSON.stringify(perAccount)),
        { wait: 2_000, maxWait: 30_000 })

    return {
        unload: () => save.flush(), // Flush any pending saves
        middleware: ctx => async () => {
            const u = getCurrentUsername(ctx) || undefined
            const accountConfig = _.find(api.getConfig('perAccount'), { username: u })
            const quota = 1024 * 1024 * ((u && accountConfig?.megabytes) ?? api.getConfig('megabytes'))
            const account = u && (perAccount[u] ||= { b: 0 })

            // Check if the account is expired
            if (accountConfig?.expire && new Date(accountConfig.expire) < new Date()) {
                ctx.status = api.Const.HTTP_FORBIDDEN
                ctx.type = 'application/json'
                ctx.body = JSON.stringify({
                    error: "QuotaExpired",
                    message: "Your download quota has expired.\nMeans your account has expired.You can't login to download. Please go to www.template.com",
					
                })
                return
            }

            const left = quota - account?.b

            if (ctx.path === api.Const.API_URI + PREFIX + 'status') {
                ctx.status = 200
                return ctx.body = u ? JSON.stringify({ left }) : ''
            }

            if (!account) return // Only with accounts
            if (ctx.status >= 300 || ctx.state.download_counter_ignore || ctx.state.considerAsGui) return
            if (!(ctx.state.vfsNode || ctx.state.archive)) return // Not a download

            const size = ctx.length
            if (left < size) {
                ctx.status = api.Const.HTTP_TOO_MANY_REQUESTS
                ctx.type = 'application/json'
                ctx.set('content-disposition', '')
                const { t } = await api.i18n(ctx)
                ctx.body = JSON.stringify({
                    error: "QuotaExceeded",
                    message: t('downloadQuota_insufficient_quota', 
                        { left: formatBytes(left) },
                        "Cannot download file because only {left} of your quota is left."
                    ),
                    quotaLeft: formatBytes(left)
                })
                return
            }

            account.b += size
            save()

            const ofs = ctx.socket.bytesWritten
            ctx.socket.on('close', () => {
                const actual = ctx.socket.bytesWritten - ofs
                const diff = size - actual
                if (diff <= 0) return
                account.b -= diff
                save()
            })
        }
    }
}

[rejetto]

i still fail to see how this is different from the normal account expiration offered by hfs.
from what i see here, it seems that your "quota expiration" is stopping the account completely, not just the quota.