From 17e17f502594885baf51af5c11b420f80e6e1068 Mon Sep 17 00:00:00 2001 From: Vasileios Karakasis Date: Tue, 29 Apr 2025 19:37:42 +0200 Subject: [PATCH 1/2] Use always `|` to join unique values in column aggregations --- reframe/frontend/reporting/__init__.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/reframe/frontend/reporting/__init__.py b/reframe/frontend/reporting/__init__.py index 289571a8c..3fdbb2cfa 100644 --- a/reframe/frontend/reporting/__init__.py +++ b/reframe/frontend/reporting/__init__.py @@ -647,12 +647,10 @@ def _group_testcases(testcases, groups, columns): def _aggregate_perf(grouped_testcases, aggr_fn, cols): # Update delimiter for joining unique values based on the table format table_foramt = runtime().get_option('general/0/table_format') - if table_foramt == 'csv': - delim = '|' - elif table_foramt == 'plain': - delim = ',' - else: + if table_foramt == 'pretty': delim = '\n' + else: + delim = '|' other_aggr = Aggregator.create('join_uniq', delim) count_aggr = Aggregator.create('count') From 568f3b271d295f12b20e21d9350a749b8c236c1e Mon Sep 17 00:00:00 2001 From: Vasileios Karakasis Date: Mon, 5 May 2025 16:26:29 +0200 Subject: [PATCH 2/2] Fix typo in local variable name --- reframe/frontend/reporting/__init__.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/reframe/frontend/reporting/__init__.py b/reframe/frontend/reporting/__init__.py index 3fdbb2cfa..a2d1b05bd 100644 --- a/reframe/frontend/reporting/__init__.py +++ b/reframe/frontend/reporting/__init__.py @@ -646,8 +646,8 @@ def _group_testcases(testcases, groups, columns): @time_function def _aggregate_perf(grouped_testcases, aggr_fn, cols): # Update delimiter for joining unique values based on the table format - table_foramt = runtime().get_option('general/0/table_format') - if table_foramt == 'pretty': + table_format = runtime().get_option('general/0/table_format') + if table_format == 'pretty': delim = '\n' else: delim = '|'