Skip to content

refactor(core): Use wildcard ESM import for qs #6911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pcfreak30
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

What is the current behavior?

What is the new behavior?

fixes #6910

Notes for reviewers

@pcfreak30 pcfreak30 requested a review from a team as a code owner August 1, 2025 07:11
Copy link

changeset-bot bot commented Aug 1, 2025

⚠️ No Changeset found

Latest commit: 305bcf0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Aug 1, 2025

Deploy Preview for refine-doc-live-previews ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 305bcf0
🔍 Latest deploy log https://app.netlify.com/projects/refine-doc-live-previews/deploys/688c68b11d024d000893e79e
😎 Deploy Preview https://deploy-preview-6911--refine-doc-live-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pcfreak30
Copy link
Author

This one might be trickier b/c all imports are require and the maintainer is current resistant to creating a ESM variant. the vite commonjs plugin doesn't seem to help, for dev mode, atleast

@pcfreak30 pcfreak30 marked this pull request as draft August 1, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] qs ESM importing
1 participant