Skip to content

Commit a849e73

Browse files
committed
Remove Add/Sub/Mul/Div/Rem impls for &OrderedFloat
These caused type infernence errors due to a bug in rustc. Fixes #105.
1 parent 61975f1 commit a849e73

File tree

2 files changed

+0
-26
lines changed

2 files changed

+0
-26
lines changed

src/lib.rs

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -253,18 +253,6 @@ macro_rules! impl_ordered_float_binop {
253253
}
254254
}
255255

256-
impl<'a, T> $imp for &'a OrderedFloat<T>
257-
where
258-
&'a T: $imp,
259-
{
260-
type Output = OrderedFloat<<&'a T as $imp>::Output>;
261-
262-
#[inline]
263-
fn $method(self, other: Self) -> Self::Output {
264-
OrderedFloat((self.0).$method(&other.0))
265-
}
266-
}
267-
268256
impl<'a, T> $imp<OrderedFloat<T>> for &'a OrderedFloat<T>
269257
where
270258
&'a T: $imp<T>,
@@ -301,19 +289,6 @@ macro_rules! impl_ordered_float_binop {
301289
}
302290
}
303291

304-
#[doc(hidden)] // Added accidentally; remove in next major version
305-
impl<'a, T> $imp<&'a Self> for &'a OrderedFloat<T>
306-
where
307-
&'a T: $imp,
308-
{
309-
type Output = OrderedFloat<<&'a T as $imp>::Output>;
310-
311-
#[inline]
312-
fn $method(self, other: &'a Self) -> Self::Output {
313-
OrderedFloat((self.0).$method(&other.0))
314-
}
315-
}
316-
317292
impl<T: $assign_imp> $assign_imp<T> for OrderedFloat<T> {
318293
#[inline]
319294
fn $assign_method(&mut self, other: T) {

tests/test.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -599,7 +599,6 @@ fn add() {
599599
assert_eq!(OrderedFloat(0.0) + OrderedFloat(0.0), 0.0);
600600
assert_eq!(OrderedFloat(0.0) + &OrderedFloat(0.0), 0.0);
601601
assert_eq!(&OrderedFloat(0.0) + OrderedFloat(0.0), 0.0);
602-
assert_eq!(&OrderedFloat(0.0) + &OrderedFloat(0.0), 0.0);
603602
assert_eq!(OrderedFloat(0.0) + 0.0, 0.0);
604603
assert_eq!(OrderedFloat(0.0) + &0.0, 0.0);
605604
assert_eq!(&OrderedFloat(0.0) + 0.0, 0.0);

0 commit comments

Comments
 (0)