Skip to content

Commit 2a33ec6

Browse files
committed
Update to Serde 1.0
1 parent aa7e23b commit 2a33ec6

File tree

2 files changed

+7
-9
lines changed

2 files changed

+7
-9
lines changed

Cargo.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@ repository = "https://github.com/reem/rust-ordered-float"
99

1010
[dependencies]
1111
num-traits = { version = "0.1", default_features = false }
12-
serde = { version = "0.9", optional = true }
12+
serde = { version = "1.0", optional = true }
1313
rustc-serialize = { version = "0.3", optional = true }
1414
unreachable = "0.1"
1515

1616
[dev-dependencies]
1717
stainless = "0.1"
18-
serde_test = "0.9"
18+
serde_test = "1.0"

src/lib.rs

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -605,17 +605,15 @@ mod impl_serde {
605605
extern crate serde_test;
606606
#[cfg(test)]
607607
use self::serde_test::{Token, assert_tokens, assert_de_tokens_error};
608-
#[cfg(test)]
609-
use self::serde_test::Error::Message;
610608

611609
impl<T: Float + Serialize> Serialize for OrderedFloat<T> {
612610
fn serialize<S: Serializer>(&self, s: S) -> Result<S::Ok, S::Error> {
613611
self.0.serialize(s)
614612
}
615613
}
616614

617-
impl<T: Float + Deserialize> Deserialize for OrderedFloat<T> {
618-
fn deserialize<D: Deserializer>(d: D) -> Result<Self, D::Error> {
615+
impl<'de, T: Float + Deserialize<'de>> Deserialize<'de> for OrderedFloat<T> {
616+
fn deserialize<D: Deserializer<'de>>(d: D) -> Result<Self, D::Error> {
619617
T::deserialize(d).map(OrderedFloat)
620618
}
621619
}
@@ -626,8 +624,8 @@ mod impl_serde {
626624
}
627625
}
628626

629-
impl<T: Float + Deserialize> Deserialize for NotNaN<T> {
630-
fn deserialize<D: Deserializer>(d: D) -> Result<Self, D::Error> {
627+
impl<'de, T: Float + Deserialize<'de>> Deserialize<'de> for NotNaN<T> {
628+
fn deserialize<D: Deserializer<'de>>(d: D) -> Result<Self, D::Error> {
631629
let float = T::deserialize(d)?;
632630
NotNaN::new(float).map_err(|_| {
633631
Error::invalid_value(Unexpected::Float(f64::NAN), &"float (but not NaN)")
@@ -651,6 +649,6 @@ mod impl_serde {
651649
fn test_fail_on_nan() {
652650
assert_de_tokens_error::<NotNaN<f64>>(
653651
&[Token::F64(f64::NAN)],
654-
Message("invalid value: floating point `NaN`, expected float (but not NaN)".into()));
652+
"invalid value: floating point `NaN`, expected float (but not NaN)");
655653
}
656654
}

0 commit comments

Comments
 (0)