Skip to content

Commit 4831283

Browse files
committed
Filter devices ending in numbers like NVMe
1 parent 2bbaaac commit 4831283

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

tasks/01_install_hdd_temp.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,15 @@
2323

2424
# Get the last device letter from each active device, this is needed for hddtmp monitoring
2525
# If "disk_devices" contains ['sda','sdb','sdc'] then device_letters is "abc"
26+
# Devices ending in numbers like nvme1 which are not supported are skipped
2627
- name: Construct device letter string
2728
set_fact:
2829
device_letters: "{{device_letters|default('') + item[-1]}}"
2930
loop:
30-
"{{disk_devices}}"
31+
"{{disk_devices}}"
3132
loop_control:
3233
label: "{{disk_devices}}"
34+
when: item[-1] | lower | regex_search("[a-z]")
3335

3436
# hddtemp can only take a limited number of devices; which is a limit on the number of
3537
# parameters which can be passed via the command line. Break up the disk device list
@@ -38,6 +40,8 @@
3840
- name: "Chunk device letter string by {{hddtemp_num_devices}}"
3941
set_fact:
4042
device_letters: "{{ device_letters | regex_findall('.{1,' + hddtemp_num_devices|string +'}') }}"
43+
when:
44+
device_letters is defined
4145

4246
- name: Creates @reboot CRON entry for HDDTemp instances
4347
cron:
@@ -49,6 +53,8 @@
4953
loop_control:
5054
index_var: hddtemp_num_instances
5155
label: "job: /usr/sbin/hddtemp -d /dev/sd[{{item}}]"
56+
when:
57+
device_letters is defined
5258

5359
tags:
5460
- install_hdd_temp

0 commit comments

Comments
 (0)