Big O of createEntity adapter

[Sivaranjith1]

Does the createEntity adapter have a O(1) or does is scale with the amount of data. We are experience some issues where having more data would cause the dispatch(entity.actions.updateMany()) to be slower.

[phryneas]

It should be in O(numberOfUpdatedItems) plus the overhead of immer.

How many items are you talking about here?

[Sivaranjith1]

Its a 1000 elements, and I update 4 of them very frequently. Some are updated on mouse move

[phryneas]

That would not take a lot of time, but "on mouse move" could be hundreds of times per second. You need to debounce that to something more sensible like one dispatch per second or so.

[Sivaranjith1]

Debouncing sounds like a good idea. I however tested with console.time for the updateMany from the create entityAdapter. It however does not look like O(1) + overhead since in both cases I only update when property

With a lot of elements in the state

With few elements in the state

[phryneas]

Going by https://immerjs.github.io/immer/performance/, you would see those 50ms probably in an environment when changing 5k of 50k, not when changing only 4 of 1000.

If you look at the source code of updateMany, you can see that what happens here on our side is essentially - it's not a lot of code, and everything there scales by the number of updates, not with the length of your array.

[markerikson]

What entity adapter methods are you using?

(also, this should be in the Redux Toolkit repo - moving it over there)