Typing selectFromResult as a standalone function

[hornta]

I'm trying to extract a selectFromResult function to it's own function outside of calling the endpoint via react hooks, so that I may use it for multiple endpoints but I'm unsure of how to type it correctly. What's the template parameter supposed to be?

const accountItemSelector: QueryStateSelector<unknown> = ({
  data,
  ...result
}) => {
  if (data) {
    const accounts: Item[] = [];
    const nodesToCheck = [...data.uddHierarchy.hierarchies];
    let node: RenderTree | undefined;
    while ((node = nodesToCheck.pop())) {
      nodesToCheck.push(...node.children);
      accounts.push(...node.items);
    }
    accounts.sort((a, b) => {
      return Number(a.id) - Number(b.id);
    });
    return { accounts, ...result };
  }
  return { accounts: [], ...result };
};

I gave it a try and managed to make it work would you believe that, however I had to patch redux by exporting UseQueryStateDefaultResult. It's not pretty and I'm sure there's a nicer way.

type ExtractQueryDefinition<Type> = Type extends ApiEndpointQuery<
  infer X,
  never
>
  ? X
  : never;

type GetAccountHierarchyDefinition = ExtractQueryDefinition<
  typeof exopenApi.endpoints.getAccountHierarchy
>;

const accountItemSelector: QueryStateSelector<
  { accounts: Item[] } & Omit<
    UseQueryStateDefaultResult<GetAccountHierarchyDefinition>,
    "data"
  >,
  GetAccountHierarchyDefinition
> = ({ data, ...result }) => {
  const accounts: Item[] = [];
  if (data) {
    const nodesToCheck = [...data.uddHierarchy.hierarchies];
    let node: RenderTree | undefined;
    while ((node = nodesToCheck.pop())) {
      nodesToCheck.push(...node.children);
      accounts.push(...node.items);
    }
    accounts.sort((a, b) => {
      return Number(a.id) - Number(b.id);
    });
  }
  return { accounts, ...result };
};

[phryneas]

Take a look at #2276 - we export some "more nicely typed" exports there. I'm not sure if adding a TypedQueryStateSelector would help there, but it might 🤔

Could you maybe do a PR against that PR? ^^