add TS 4.3 to test matrix, disable strictOptionalProperties for TS4.4 (#1137)

* add TS 4.3 to test matrix, disable `strictOptionalProperties` for TS4.4

* tweaks

* comment

* add any cast in error cases for TS 4.4

Author: phryneas

.github/workflows/tests.yml

@@ -78,7 +78,7 @@ jobs:
       fail-fast: false
       matrix:
         node: ['14.x']
-        ts: ['3.9', '4.0', '4.1', '4.2', 'next']
+        ts: ['3.9', '4.0', '4.1', '4.2', '4.3', 'next']
     steps:
       - name: Checkout repo
         uses: actions/checkout@v2
@@ -110,6 +110,10 @@ jobs:
         if: ${{ matrix.ts < 4.1 }}
         run: sed -i -e 's/@pre41-ts-ignore/@ts-ignore/' -e  '/pre41-remove-start/,/pre41-remove-end/d' ./src/tests/*.* ./src/query/tests/*.ts*
 
+      - name: 'disable strictOptionalProperties'
+        if: ${{ matrix.ts == 'next' }}
+        run: sed -i -e 's|//\(.*strictOptionalProperties.*\)$|\1|' tsconfig.base.json
+
       - name: Test types
         run: |
           ./node_modules/.bin/tsc --version

src/createAsyncThunk.ts

@@ -604,7 +604,7 @@ If you want to use the AbortController to react to \`abort\` events, please cons
           finalAction =
             err instanceof RejectWithValue
               ? rejected(null, requestId, arg, err.payload, err.meta)
-              : rejected(err, requestId, arg)
+              : rejected(err as any, requestId, arg)
         }
         // We dispatch the result action _after_ the catch, to avoid having any errors
         // here get swallowed by the try/catch block,

src/query/core/module.ts

@@ -121,7 +121,7 @@ declare module '../apiTypes' {
         ThunkDispatch<any, any, AnyAction>
       >
       /**
-       * TODO
+       * A collection of utility thunks for various situations.
        */
       util: {
         /**
@@ -130,7 +130,7 @@ declare module '../apiTypes' {
          * The thunk accepts three arguments: the name of the endpoint we are updating (such as `'getPost'`), any relevant query arguments, and a set of options used to determine if the data actually should be re-fetched based on cache staleness.
          *
          * React Hooks users will most likely never need to use this directly, as the `usePrefetch` hook will dispatch this thunk internally as needed when you call the prefetching function supplied by the hook.
-         * 
+         *
          * @example
          *
          * ```ts no-transpile

src/tests/createAsyncThunk.test.ts

@@ -323,7 +323,7 @@ describe('createAsyncThunk', () => {
         try {
           throw error
         } catch (err) {
-          if (!err.response) {
+          if (!(err as any).response) {
             throw err
           }
           return rejectWithValue(errorPayload)

src/tests/createAsyncThunk.typetest.ts

@@ -163,7 +163,7 @@ const anyAction = { type: 'foo' } as AnyAction
       )
       return result.data.data
     } catch (err) {
-      let error: AxiosError<ErrorFromServer> = err // cast for access to AxiosError properties
+      let error: AxiosError<ErrorFromServer> = err as any // cast for access to AxiosError properties
       if (!error.response) {
         // let it be handled as any other unknown error
         throw err

tsconfig.base.json

@@ -10,6 +10,7 @@
     "rootDir": "./src",
     // stricter type-checking for stronger correctness. Recommended by TS
     "strict": true,
+    // "strictOptionalProperties": false, // disable strictOptionalProperties for now to also build with 4.4
     // linter checks for common issues
     "noImplicitReturns": true,
     "noFallthroughCasesInSwitch": true,