Remove unused ESLint disable directives

aryaemami59 · aryaemami59 · commit f8fe2b597b58 · 2024-09-13T22:13:34.000-05:00
diff --git a/packages/toolkit/src/createAsyncThunk.ts b/packages/toolkit/src/createAsyncThunk.ts
@@ -601,7 +601,6 @@ export const createAsyncThunk = /* @__PURE__ */ (() => {
             }
 
             if (conditionResult === false || abortController.signal.aborted) {
-              // eslint-disable-next-line no-throw-literal
               throw {
                 name: 'ConditionError',
                 message: 'Aborted due to condition callback returning false.',
diff --git a/packages/toolkit/src/createSlice.ts b/packages/toolkit/src/createSlice.ts
@@ -437,9 +437,10 @@ export type SliceCaseReducers<State> =
 /**
  * The type describing a slice's `selectors` option.
  */
-export type SliceSelectors<State> = {
-  [K: string]: (sliceState: State, ...args: any[]) => any
-}
+export type SliceSelectors<State> = Record<
+  string,
+  (sliceState: State, ...args: any[]) => any
+>
 
 type SliceActionType<
   SliceName extends string,
diff --git a/packages/toolkit/src/entities/tests/sorted_state_adapter.test.ts b/packages/toolkit/src/entities/tests/sorted_state_adapter.test.ts
@@ -21,7 +21,6 @@ describe('Sorted State Adapter', () => {
   let state: EntityState<BookModel, string>
 
   beforeAll(() => {
-    //eslint-disable-next-line
     Object.defineProperty(Array.prototype, 'unwantedField', {
       enumerable: true,
       configurable: true,
diff --git a/packages/toolkit/src/entities/tests/unsorted_state_adapter.test.ts b/packages/toolkit/src/entities/tests/unsorted_state_adapter.test.ts
@@ -14,7 +14,6 @@ describe('Unsorted State Adapter', () => {
   let state: EntityState<BookModel, string>
 
   beforeAll(() => {
-    //eslint-disable-next-line
     Object.defineProperty(Array.prototype, 'unwantedField', {
       enumerable: true,
       configurable: true,
diff --git a/packages/toolkit/src/entities/unsorted_state_adapter.ts b/packages/toolkit/src/entities/unsorted_state_adapter.ts
@@ -102,7 +102,7 @@ export function createUnsortedStateAdapter<T, Id extends EntityId>(
   }
 
   function takeNewKey(
-    keys: { [id: string]: Id },
+    keys: Record<string, Id>,
     update: Update<T, Id>,
     state: R,
   ): boolean {
@@ -132,9 +132,9 @@ export function createUnsortedStateAdapter<T, Id extends EntityId>(
     updates: ReadonlyArray<Update<T, Id>>,
     state: R,
   ): void {
-    const newKeys: { [id: string]: Id } = {}
+    const newKeys: Record<string, Id> = {}
 
-    const updatesPerEntity: { [id: string]: Update<T, Id> } = {}
+    const updatesPerEntity: Record<string, Update<T, Id>> = {}
 
     updates.forEach((update) => {
       // Only apply updates to entities that currently exist
diff --git a/packages/toolkit/src/immutableStateInvariantMiddleware.ts b/packages/toolkit/src/immutableStateInvariantMiddleware.ts
@@ -35,8 +35,8 @@ function trackProperties(
   isImmutable: IsImmutableFunc,
   ignorePaths: IgnorePaths = [],
   obj: Record<string, any>,
-  path: string = '',
-  checkedObjects: Set<Record<string, any>> = new Set(),
+  path = '',
+  checkedObjects = new Set<Record<string, any>>(),
 ) {
   const tracked: Partial<TrackedProperty> = { value: obj }
 
@@ -66,8 +66,8 @@ function detectMutations(
   ignoredPaths: IgnorePaths = [],
   trackedProperty: TrackedProperty,
   obj: any,
-  sameParentRef: boolean = false,
-  path: string = '',
+  sameParentRef = false,
+  path = '',
 ): { wasMutated: boolean; path?: string } {
   const prevObj = trackedProperty ? trackedProperty.value : undefined
 
diff --git a/packages/toolkit/src/query/core/apiState.ts b/packages/toolkit/src/query/core/apiState.ts
@@ -108,7 +108,7 @@ export type SubscriptionOptions = {
    */
   refetchOnFocus?: boolean
 }
-export type Subscribers = { [requestId: string]: SubscriptionOptions }
+export type Subscribers = Record<string, SubscriptionOptions>
 export type QueryKeys<Definitions extends EndpointDefinitions> = {
   [K in keyof Definitions]: Definitions[K] extends QueryDefinition<
     any,
@@ -245,13 +245,12 @@ export type InvalidationState<TagTypes extends string> = {
   }
 }
 
-export type QueryState<D extends EndpointDefinitions> = {
-  [queryCacheKey: string]: QuerySubState<D[string]> | undefined
-}
+export type QueryState<D extends EndpointDefinitions> = Record<
+  string,
+  QuerySubState<D[string]> | undefined
+>
 
-export type SubscriptionState = {
-  [queryCacheKey: string]: Subscribers | undefined
-}
+export type SubscriptionState = Record<string, Subscribers | undefined>
 
 export type ConfigState<ReducerPath> = RefetchConfigOptions & {
   reducerPath: ReducerPath
@@ -265,9 +264,10 @@ export type ModifiableConfigState = {
   invalidationBehavior: 'delayed' | 'immediately'
 } & RefetchConfigOptions
 
-export type MutationState<D extends EndpointDefinitions> = {
-  [requestId: string]: MutationSubState<D[string]> | undefined
-}
+export type MutationState<D extends EndpointDefinitions> = Record<
+  string,
+  MutationSubState<D[string]> | undefined
+>
 
 export type RootState<
   Definitions extends EndpointDefinitions,
diff --git a/packages/toolkit/src/query/core/buildInitiate.ts b/packages/toolkit/src/query/core/buildInitiate.ts
@@ -199,14 +199,14 @@ export function buildInitiate({
   api: Api<any, EndpointDefinitions, any, any>
   context: ApiContext<EndpointDefinitions>
 }) {
-  const runningQueries: Map<
+  const runningQueries = new Map<
     Dispatch,
     Record<string, QueryActionCreatorResult<any> | undefined>
-  > = new Map()
-  const runningMutations: Map<
+  >()
+  const runningMutations = new Map<
     Dispatch,
     Record<string, MutationActionCreatorResult<any> | undefined>
-  > = new Map()
+  >()
 
   const {
     unsubscribeQueryResult,
diff --git a/packages/toolkit/src/query/core/buildThunks.ts b/packages/toolkit/src/query/core/buildThunks.ts
@@ -604,7 +604,7 @@ In the case of an unhandled error, no tags will be "provided" or "invalidated".`
       const force = hasTheForce(options) && options.force
       const maxAge = hasMaxAge(options) && options.ifOlderThan
 
-      const queryAction = (force: boolean = true) => {
+      const queryAction = (force = true) => {
         const options = { forceRefetch: force, isPrefetch: true }
         return (
           api.endpoints[endpointName] as ApiEndpointQuery<any, any>
diff --git a/packages/toolkit/src/query/core/module.ts b/packages/toolkit/src/query/core/module.ts
@@ -85,7 +85,6 @@ export type CoreModule =
 export type ThunkWithReturnValue<T> = ThunkAction<T, any, any, UnknownAction>
 
 export interface ApiModules<
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   BaseQuery extends BaseQueryFn,
   Definitions extends EndpointDefinitions,
   ReducerPath extends string,
@@ -396,9 +395,7 @@ export interface ApiModules<
 }
 
 export interface ApiEndpointQuery<
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   Definition extends QueryDefinition<any, any, any, any, any>,
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   Definitions extends EndpointDefinitions,
 > extends BuildThunksApiEndpointQuery<Definition>,
     BuildInitiateApiEndpointQuery<Definition>,
@@ -410,11 +407,8 @@ export interface ApiEndpointQuery<
   Types: NonNullable<Definition['Types']>
 }
 
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
 export interface ApiEndpointMutation<
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   Definition extends MutationDefinition<any, any, any, any, any>,
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   Definitions extends EndpointDefinitions,
 > extends BuildThunksApiEndpointMutation<Definition>,
     BuildInitiateApiEndpointMutation<Definition>,
diff --git a/packages/toolkit/src/query/react/module.ts b/packages/toolkit/src/query/react/module.ts
@@ -28,12 +28,9 @@ export type ReactHooksModule = typeof reactHooksModuleName
 
 declare module '@reduxjs/toolkit/query' {
   export interface ApiModules<
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
     BaseQuery extends BaseQueryFn,
     Definitions extends EndpointDefinitions,
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
     ReducerPath extends string,
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
     TagTypes extends string,
   > {
     [reactHooksModuleName]: {
diff --git a/packages/toolkit/src/query/retry.ts b/packages/toolkit/src/query/retry.ts
@@ -22,7 +22,7 @@ import { HandledError } from './HandledError'
  * @param attempt - Current attempt
  * @param maxRetries - Maximum number of retries
  */
-async function defaultBackoff(attempt: number = 0, maxRetries: number = 5) {
+async function defaultBackoff(attempt = 0, maxRetries = 5) {
   const attempts = Math.min(attempt, maxRetries)
 
   const timeout = ~~((Math.random() + 0.4) * (300 << attempts)) // Force a positive int in the case we make this an option
@@ -103,7 +103,6 @@ const retryWithBackoff: BaseQueryEnhancer<
   }
   let retry = 0
 
-  // eslint-disable-next-line no-constant-condition
   while (true) {
     try {
       const result = await baseQuery(args, api, extraOptions)
diff --git a/packages/toolkit/src/query/tests/optimisticUpserts.test.tsx b/packages/toolkit/src/query/tests/optimisticUpserts.test.tsx
@@ -300,7 +300,7 @@ describe('upsertQueryData', () => {
   test('upsert while a normal query is running (rejected)', async () => {
     baseQuery.mockImplementationOnce(async () => {
       await delay(20)
-      // eslint-disable-next-line no-throw-literal
+
       throw 'Error!'
     })
     const upsertedData = {
diff --git a/packages/toolkit/src/query/tests/retry.test.ts b/packages/toolkit/src/query/tests/retry.test.ts
@@ -6,7 +6,7 @@ beforeEach(() => {
   vi.useFakeTimers()
 })
 
-const loopTimers = async (max: number = 12) => {
+const loopTimers = async (max = 12) => {
   let count = 0
   while (count < max) {
     await vi.advanceTimersByTimeAsync(1)
diff --git a/packages/toolkit/src/serializableStateInvariantMiddleware.ts b/packages/toolkit/src/serializableStateInvariantMiddleware.ts
@@ -35,7 +35,7 @@ export type IgnorePaths = readonly (string | RegExp)[]
  */
 export function findNonSerializableValue(
   value: unknown,
-  path: string = '',
+  path = '',
   isSerializable: (value: unknown) => boolean = isPlain,
   getEntries?: (value: unknown) => [string, any][],
   ignoredPaths: IgnorePaths = [],
diff --git a/packages/toolkit/src/tests/createAsyncThunk.test-d.ts b/packages/toolkit/src/tests/createAsyncThunk.test-d.ts
@@ -165,7 +165,7 @@ describe('type tests', () => {
 
   test('regression #1156: union return values fall back to allowing only single member', () => {
     const fn = createAsyncThunk('session/isAdmin', async () => {
-      const response: boolean = false
+      const response = false
       return response
     })
   })
diff --git a/packages/toolkit/src/tests/createSlice.test.ts b/packages/toolkit/src/tests/createSlice.test.ts
@@ -350,7 +350,6 @@ describe('createSlice', () => {
           },
         },
         extraReducers(builder) {
-          // eslint-disable-next-line @typescript-eslint/no-use-before-define
           builder.addCase(second.actions.other, () => {
             return 'firstOther'
           })

Original file line number	Diff line number	Diff line change
`@@ -601,7 +601,6 @@ export const createAsyncThunk = /* @__PURE__ */ (() => {`
`601`	`601`	`}`
`602`	`602`
`603`	`603`	`if (conditionResult === false \|\| abortController.signal.aborted) {`
`604`		`- // eslint-disable-next-line no-throw-literal`
`605`	`604`	`throw {`
`606`	`605`	`name: 'ConditionError',`
`607`	`606`	`message: 'Aborted due to condition callback returning false.',`