Skip to content

Commit ce98d69

Browse files
authored
Merge pull request #2643 from reduxjs/bugfix/1.9-ts4.8-fixes
2 parents 67b6ed2 + 38f0f7d commit ce98d69

File tree

10 files changed

+51
-161
lines changed

10 files changed

+51
-161
lines changed
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
diff --git a/lib/types/context/set.d.ts b/lib/types/context/set.d.ts
2+
index 266229bad706ec49392b8b87e18560c1566b490d..4fad485f8ffec2db92e808a05ccd9274414a9bd9 100644
3+
--- a/lib/types/context/set.d.ts
4+
+++ b/lib/types/context/set.d.ts
5+
@@ -15,4 +15,5 @@ export declare type ForbiddenHeaderError<HeaderName extends string> = `SafeRespo
6+
* })
7+
* @see {@link https://mswjs.io/docs/api/context/set `ctx.set()`}
8+
*/
9+
+// @ts-ignore
10+
export declare function set<N extends string | HeadersObject>(...args: N extends string ? Lowercase<N> extends ForbiddenHeaderNames ? ForbiddenHeaderError<N> : [N, string] : N extends HeadersObject<infer CookieName> ? Lowercase<CookieName> extends ForbiddenHeaderNames ? ForbiddenHeaderError<CookieName> : [N] : [N]): ResponseTransformer;
11+
diff --git a/lib/types/sharedOptions.d.ts b/lib/types/sharedOptions.d.ts
12+
index d1d6e05df2dc2c29f06d8d0b91c500a10e651a29..3d8c29fd2089b2abf21d78cd277aac9271e781c2 100644
13+
--- a/lib/types/sharedOptions.d.ts
14+
+++ b/lib/types/sharedOptions.d.ts
15+
@@ -21,4 +21,5 @@ export interface LifeCycleEventsMap<ResponseType> {
16+
'response:bypass': (response: ResponseType, requestId: string) => void;
17+
unhandledException: (error: Error, request: MockedRequest) => void;
18+
}
19+
+// @ts-ignore
20+
export declare type LifeCycleEventEmitter<ResponseType> = Pick<StrictEventEmitter<ResponseType>, 'on' | 'removeListener' | 'removeAllListeners'>;

examples/query/react/basic/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
"@types/jest": "^26.0.23",
1818
"@types/react": "^18.0.5",
1919
"@types/react-dom": "^18.0.5",
20-
"msw": "^0.41.1",
20+
"msw": "^0.40.2",
2121
"typescript": "~4.2.4"
2222
},
2323
"eslintConfig": {

examples/query/react/graphql-codegen/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"framer-motion": "^2.9.5",
1616
"graphql": "^15.5.0",
1717
"graphql-request": "^3.4.0",
18-
"msw": "0.28.2",
18+
"msw": "0.40.2",
1919
"react": "^18.1.0",
2020
"react-dom": "^18.1.0",
2121
"react-icons": "3.11.0",

examples/query/react/graphql/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"framer-motion": "^2.9.5",
1717
"graphql": "^15.5.0",
1818
"graphql-request": "^3.4.0",
19-
"msw": "0.28.2",
19+
"msw": "0.40.2",
2020
"react": "^18.1.0",
2121
"react-dom": "^18.1.0",
2222
"react-icons": "3.11.0",

package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@
3838
},
3939
"resolutions": {
4040
"console-testing-library": "patch:console-testing-library@npm:0.3.1#.yarn/patches/console-testing-library__npm_0.3.1.patch",
41+
"msw": "patch:msw@npm:0.40.2#.yarn/patches/msw-npm-0.40.2-2107d48752",
4142
"react-redux": "npm:8.0.2",
4243
"react": "npm:18.1.0",
4344
"react-dom": "npm:18.1.0",
@@ -51,7 +52,8 @@
5152
"docs/react": "npm:17.0.2",
5253
"docs/react-dom": "npm:17.0.2",
5354
"docs/@types/react-dom": "npm:17.0.11",
54-
"docs/@types/react": "npm:17.0.11"
55+
"docs/@types/react": "npm:17.0.11",
56+
"type-fest": "2.19.0"
5557
},
5658
"scripts": {
5759
"build": "yarn build:packages",

packages/rtk-query-codegen-openapi/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
"esbuild-runner": "^2.2.1",
4848
"husky": "^4.3.6",
4949
"jest": "^27",
50-
"msw": "^0.41.1",
50+
"msw": "^0.40.2",
5151
"openapi-types": "^9.1.0",
5252
"pretty-quick": "^3.1.0",
5353
"ts-jest": "^27",

packages/toolkit/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
"json-stringify-safe": "^5.0.1",
6262
"magic-string": "^0.25.7",
6363
"merge-source-map": "^1.1.0",
64-
"msw": "^0.41.1",
64+
"msw": "^0.40.2",
6565
"node-fetch": "^2.6.1",
6666
"prettier": "^2.2.1",
6767
"query-string": "^7.0.1",

packages/toolkit/src/createAsyncThunk.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -420,7 +420,7 @@ type OverrideThunkApiConfigs<OldConfig, NewConfig> = Id<
420420
NewConfig & Omit<OldConfig, keyof NewConfig>
421421
>
422422

423-
type CreateAsyncThunk<CurriedThunkApiConfig> = {
423+
type CreateAsyncThunk<CurriedThunkApiConfig extends AsyncThunkConfig> = {
424424
/**
425425
*
426426
* @param typePrefix

packages/toolkit/src/query/react/buildHooks.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@ import type { BaseQueryFn } from '../baseQueryTypes'
5858
// Copy-pasted from React-Redux
5959
export const useIsomorphicLayoutEffect =
6060
typeof window !== 'undefined' &&
61-
window.document &&
62-
window.document.createElement
61+
!!window.document &&
62+
!!window.document.createElement
6363
? useLayoutEffect
6464
: useEffect
6565

0 commit comments

Comments
 (0)