Replace all Function references with AnyFunction

aryaemami59 · aryaemami59 · commit 75a378688443 · 2025-05-17T16:39:09.000-05:00
diff --git a/docs/api/actionCreatorMiddleware.mdx b/docs/api/actionCreatorMiddleware.mdx
@@ -54,7 +54,7 @@ import reducer from './reducer'
 // Augment middleware to consider all functions with a static type property to be action creators
 const isActionCreator = (
   action: unknown,
-): action is Function & { type: unknown } =>
+): action is (...args: any) => any & { type: unknown } =>
   typeof action === 'function' && 'type' in action
 
 const actionCreatorMiddleware = createActionCreatorInvariantMiddleware({
diff --git a/packages/toolkit/src/actionCreatorInvariantMiddleware.ts b/packages/toolkit/src/actionCreatorInvariantMiddleware.ts
@@ -1,20 +1,23 @@
 import type { Middleware } from 'redux'
 import { isActionCreator as isRTKAction } from './createAction'
+import type { AnyFunction } from './tsHelpers'
 
 export interface ActionCreatorInvariantMiddlewareOptions {
   /**
    * The function to identify whether a value is an action creator.
    * The default checks for a function with a static type property and match method.
    */
-  isActionCreator?: (action: unknown) => action is Function & { type?: unknown }
+  isActionCreator?: (
+    action: unknown,
+  ) => action is AnyFunction & { type?: unknown }
 }
 
 export function getMessage(type?: unknown) {
   const splitType = type ? `${type}`.split('/') : []
   const actionName = splitType[splitType.length - 1] || 'actionCreator'
   return `Detected an action creator with type "${
     type || 'unknown'
-  }" being dispatched. 
+  }" being dispatched.
 Make sure you're calling the action creator before dispatching, i.e. \`dispatch(${actionName}())\` instead of \`dispatch(${actionName})\`. This is necessary even if the action has no payload.`
 }
 
diff --git a/packages/toolkit/src/createAction.ts b/packages/toolkit/src/createAction.ts
@@ -1,9 +1,10 @@
 import { isAction } from 'redux'
 import type {
-  IsUnknownOrNonInferrable,
+  AnyFunction,
   IfMaybeUndefined,
   IfVoid,
   IsAny,
+  IsUnknownOrNonInferrable,
 } from './tsHelpers'
 import { hasMatchFunction } from './tsHelpers'
 
@@ -257,7 +258,7 @@ export function createAction<
   prepareAction: PA,
 ): PayloadActionCreator<ReturnType<PA>['payload'], T, PA>
 
-export function createAction(type: string, prepareAction?: Function): any {
+export function createAction(type: string, prepareAction?: AnyFunction): any {
   function actionCreator(...args: any[]) {
     if (prepareAction) {
       const prepared = prepareAction(...args)
@@ -290,7 +291,7 @@ export function createAction(type: string, prepareAction?: Function): any {
  */
 export function isActionCreator(
   action: unknown,
-): action is BaseActionCreator<unknown, string> & Function {
+): action is BaseActionCreator<unknown, string> & AnyFunction {
   return (
     typeof action === 'function' &&
     'type' in action &&
diff --git a/packages/toolkit/src/createReducer.ts b/packages/toolkit/src/createReducer.ts
@@ -3,7 +3,7 @@ import { produce as createNextState, isDraft, isDraftable } from 'immer'
 import type { Action, Reducer, UnknownAction } from 'redux'
 import type { ActionReducerMapBuilder } from './mapBuilders'
 import { executeReducerBuilderCallback } from './mapBuilders'
-import type { NoInfer, TypeGuard } from './tsHelpers'
+import type { AnyFunction, NoInfer, TypeGuard } from './tsHelpers'
 import { freezeDraftable } from './utils'
 
 /**
@@ -63,7 +63,7 @@ export type CaseReducers<S, AS extends Actions> = {
   [T in keyof AS]: AS[T] extends Action ? CaseReducer<S, AS[T]> : void
 }
 
-export type NotFunction<T> = T extends Function ? never : T
+export type NotFunction<T> = T extends AnyFunction ? never : T
 
 function isStateFunction<S>(x: unknown): x is () => S {
   return typeof x === 'function'
diff --git a/packages/toolkit/src/createSlice.ts b/packages/toolkit/src/createSlice.ts
@@ -25,7 +25,7 @@ import type {
 import { createReducer } from './createReducer'
 import type { ActionReducerMapBuilder, TypedActionCreator } from './mapBuilders'
 import { executeReducerBuilderCallback } from './mapBuilders'
-import type { Id, TypeGuard } from './tsHelpers'
+import type { AnyFunction, Id, TypeGuard } from './tsHelpers'
 import { getOrInsertComputed } from './utils'
 
 const asyncThunkSymbol = /* @__PURE__ */ Symbol.for(
@@ -876,7 +876,7 @@ interface ReducerHandlingContext<State> {
   >
   sliceCaseReducersByType: Record<string, CaseReducer<State, any>>
   sliceMatchers: ActionMatcherDescriptionCollection<State>
-  actionCreators: Record<string, Function>
+  actionCreators: Record<string, AnyFunction>
 }
 
 interface ReducerHandlingContextMethods<State> {
@@ -927,7 +927,7 @@ interface ReducerHandlingContextMethods<State> {
    */
   exposeAction(
     name: string,
-    actionCreator: Function,
+    actionCreator: AnyFunction,
   ): ReducerHandlingContextMethods<State>
   /**
    * Add a case reducer to be exposed under the final `slice.caseReducers` key.
diff --git a/packages/toolkit/src/devtoolsExtension.ts b/packages/toolkit/src/devtoolsExtension.ts
@@ -1,5 +1,6 @@
 import type { Action, ActionCreator, StoreEnhancer } from 'redux'
 import { compose } from 'redux'
+import type { AnyFunction } from './tsHelpers'
 
 /**
  * @public
@@ -223,7 +224,7 @@ export const composeWithDevTools: ComposeWithDevTools =
     : function () {
         if (arguments.length === 0) return undefined
         if (typeof arguments[0] === 'object') return compose
-        return compose.apply(null, arguments as any as Function[])
+        return compose.apply(null, arguments as any as AnyFunction[])
       }
 
 /**
diff --git a/packages/toolkit/src/query/endpointDefinitions.ts b/packages/toolkit/src/query/endpointDefinitions.ts
@@ -1,5 +1,6 @@
 import type { Api } from '@reduxjs/toolkit/query'
 import type { StandardSchemaV1 } from '@standard-schema/spec'
+import type { AnyFunction } from '../tsHelpers'
 import type {
   BaseQueryApi,
   BaseQueryArg,
@@ -29,6 +30,7 @@ import type {
 } from './core/index'
 import type { SerializeQueryArgs } from './defaultSerializeQueryArgs'
 import type { NEVER } from './fakeBaseQuery'
+import type { NamedSchemaError } from './standardSchema'
 import type {
   CastAny,
   HasRequiredProps,
@@ -38,7 +40,6 @@ import type {
   UnwrapPromise,
 } from './tsHelpers'
 import { isNotNullish } from './utils'
-import type { NamedSchemaError } from './standardSchema'
 
 const rawResultType = /* @__PURE__ */ Symbol()
 const resultType = /* @__PURE__ */ Symbol()
@@ -872,18 +873,18 @@ export interface InfiniteQueryExtraOptions<
    * `initialPageParam` may be specified when using the
    * endpoint, to override the default value.
    * `maxPages` and `getPreviousPageParam` are both optional.
-   * 
+   *
    * @example
-   * 
+   *
    * ```ts
    * // codeblock-meta title="infiniteQueryOptions example"
    * import { createApi, fetchBaseQuery, defaultSerializeQueryArgs } from '@reduxjs/toolkit/query/react'
-   * 
+   *
    * type Pokemon = {
    *   id: string
    *   name: string
    * }
-   * 
+   *
    * const pokemonApi = createApi({
    *   baseQuery: fetchBaseQuery({ baseUrl: 'https://pokeapi.co/api/v2/' }),
    *   endpoints: (build) => ({
@@ -908,7 +909,7 @@ export interface InfiniteQueryExtraOptions<
    *     }),
    *   }),
    * })
-   
+
    * ```
    */
   infiniteQueryOptions: InfiniteQueryConfigOptions<
@@ -1371,7 +1372,7 @@ export function calculateProvidedBy<ResultType, QueryArg, ErrorType, MetaType>(
   return []
 }
 
-function isFunction<T>(t: T): t is Extract<T, Function> {
+function isFunction<T>(t: T): t is Extract<T, AnyFunction> {
   return typeof t === 'function'
 }
 
diff --git a/packages/toolkit/src/tests/actionCreatorInvariantMiddleware.test.ts b/packages/toolkit/src/tests/actionCreatorInvariantMiddleware.test.ts
@@ -1,8 +1,11 @@
 import type { ActionCreatorInvariantMiddlewareOptions } from '@internal/actionCreatorInvariantMiddleware'
-import { getMessage } from '@internal/actionCreatorInvariantMiddleware'
-import { createActionCreatorInvariantMiddleware } from '@internal/actionCreatorInvariantMiddleware'
+import {
+  createActionCreatorInvariantMiddleware,
+  getMessage,
+} from '@internal/actionCreatorInvariantMiddleware'
 import type { MiddlewareAPI } from '@reduxjs/toolkit'
 import { createAction } from '@reduxjs/toolkit'
+import type { AnyFunction } from '../tsHelpers'
 
 describe('createActionCreatorInvariantMiddleware', () => {
   const consoleSpy = vi.spyOn(console, 'warn').mockImplementation(() => {})
@@ -50,7 +53,7 @@ describe('createActionCreatorInvariantMiddleware', () => {
   it('allows passing a custom predicate', () => {
     let predicateCalled = false
     const testAction = makeActionTester({
-      isActionCreator(action): action is Function {
+      isActionCreator(action): action is AnyFunction {
         predicateCalled = true
         return false
       },
diff --git a/packages/toolkit/src/tests/createAsyncThunk.test-d.ts b/packages/toolkit/src/tests/createAsyncThunk.test-d.ts
diff --git a/packages/toolkit/src/tests/getDefaultMiddleware.test.ts b/packages/toolkit/src/tests/getDefaultMiddleware.test.ts
