Skip to content

Commit 5a36e6c

Browse files
authored
Merge pull request #3928 from reduxjs/feature/2.0-reselect-weakmapmemoize
2 parents e0a341f + dc0b467 commit 5a36e6c

File tree

5 files changed

+12
-17
lines changed

5 files changed

+12
-17
lines changed

packages/toolkit/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@
114114
"immer": "^10.0.3",
115115
"redux": "^5.0.0-rc.1",
116116
"redux-thunk": "^3.0.0-rc.0",
117-
"reselect": "^5.0.0-beta.1"
117+
"reselect": "^5.0.0-rc.0"
118118
},
119119
"peerDependencies": {
120120
"react": "^16.9.0 || ^17.0.0 || ^18",

packages/toolkit/src/createDraftSafeSelector.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { current, isDraft } from 'immer'
2-
import { createSelectorCreator, defaultMemoize } from 'reselect'
2+
import { createSelectorCreator, weakMapMemoize } from 'reselect'
33

44
export const createDraftSafeSelectorCreator: typeof createSelectorCreator = (
55
...args: unknown[]
@@ -22,4 +22,4 @@ export const createDraftSafeSelectorCreator: typeof createSelectorCreator = (
2222
* @public
2323
*/
2424
export const createDraftSafeSelector =
25-
createDraftSafeSelectorCreator(defaultMemoize)
25+
createDraftSafeSelectorCreator(weakMapMemoize)

packages/toolkit/src/index.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,7 @@ export {
1717
defaultMemoize,
1818
weakMapMemoize,
1919
} from 'reselect'
20-
export type {
21-
Selector,
22-
OutputParametricSelector,
23-
OutputSelector,
24-
ParametricSelector,
25-
} from 'reselect'
20+
export type { Selector, OutputSelector } from 'reselect'
2621
export {
2722
createDraftSafeSelector,
2823
createDraftSafeSelectorCreator,

packages/toolkit/src/query/createApi.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import { DefinitionType, isQueryDefinition } from './endpointDefinitions'
1111
import { nanoid } from './core/rtkImports'
1212
import type { UnknownAction } from '@reduxjs/toolkit'
1313
import type { NoInfer } from './tsHelpers'
14-
import { defaultMemoize } from 'reselect'
14+
import { weakMapMemoize } from 'reselect'
1515

1616
export interface CreateApiOptions<
1717
BaseQuery extends BaseQueryFn,
@@ -253,7 +253,7 @@ export function buildCreateApi<Modules extends [Module<any>, ...Module<any>[]]>(
253253
...modules: Modules
254254
): CreateApi<Modules[number]['name']> {
255255
return function baseCreateApi(options) {
256-
const extractRehydrationInfo = defaultMemoize((action: UnknownAction) =>
256+
const extractRehydrationInfo = weakMapMemoize((action: UnknownAction) =>
257257
options.extractRehydrationInfo?.(action, {
258258
reducerPath: (options.reducerPath ?? 'api') as any,
259259
})
@@ -304,7 +304,7 @@ export function buildCreateApi<Modules extends [Module<any>, ...Module<any>[]]>(
304304
},
305305
apiUid: nanoid(),
306306
extractRehydrationInfo,
307-
hasRehydrationInfo: defaultMemoize(
307+
hasRehydrationInfo: weakMapMemoize(
308308
(action) => extractRehydrationInfo(action) != null
309309
),
310310
}

yarn.lock

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7077,7 +7077,7 @@ __metadata:
70777077
query-string: ^7.0.1
70787078
redux: ^5.0.0-rc.1
70797079
redux-thunk: ^3.0.0-rc.0
7080-
reselect: ^5.0.0-beta.1
7080+
reselect: ^5.0.0-rc.0
70817081
rimraf: ^3.0.2
70827082
size-limit: ^4.11.0
70837083
tslib: ^1.10.0
@@ -25611,10 +25611,10 @@ fsevents@^1.2.7:
2561125611
languageName: node
2561225612
linkType: hard
2561325613

25614-
"reselect@npm:^5.0.0-beta.1":
25615-
version: 5.0.0-beta.1
25616-
resolution: "reselect@npm:5.0.0-beta.1"
25617-
checksum: dd707e2285c6c4d27c245634e87cf12ef5043cf01c48478f80b3e178efa8f4cd8576d56ac2691180a63704532fb3f12861df81b66ddd7819decbf64d6908779e
25614+
"reselect@npm:^5.0.0-rc.0":
25615+
version: 5.0.0-rc.0
25616+
resolution: "reselect@npm:5.0.0-rc.0"
25617+
checksum: 3de8f67e543da56261e97a4db9a677544637ec59f037b651a617cf91fb9cb32d540dc8a9aa8a36f7dbcc9997bd4c4391c53e5ac9298b983a0da9bf576688e5db
2561825618
languageName: node
2561925619
linkType: hard
2562025620

0 commit comments

Comments
 (0)