Skip to content

Commit 4be26d6

Browse files
authored
Add invalid path to the error (#1826)
1 parent 3212181 commit 4be26d6

File tree

4 files changed

+1172
-1
lines changed

4 files changed

+1172
-1
lines changed

packages/rtk-query-codegen-openapi/src/generate.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -413,7 +413,7 @@ function generatePathExpression(path: string, pathParameters: QueryArgDefinition
413413
const head = path.replace(/\{(.*?)\}(.*?)(?=\{|$)/g, (_, expression, literal) => {
414414
const param = pathParameters.find((p) => p.originalName === expression);
415415
if (!param) {
416-
throw new Error(`path parameter ${expression} does not seem to be defined?`);
416+
throw new Error(`path parameter ${expression} does not seem to be defined in '${path}'!`);
417417
}
418418
expressions.push([param.name, literal]);
419419
return '';

packages/rtk-query-codegen-openapi/test/cli.test.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,4 +77,11 @@ Done
7777
expect(fromTs).toEqual(fromJs);
7878
expect(fromJson).toEqual(fromJs);
7979
});
80+
81+
test('missing parameters doesnt fail', async () => {
82+
jest.setTimeout(25000);
83+
84+
const out = await cli([`./config.invalid-example.json`], __dirname);
85+
expect(out.stderr).toContain("Error: path parameter petId does not seem to be defined in '/pet/{petId}'!")
86+
});
8087
});
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
{
2+
"schemaFile": "./fixtures/invalid-petstore.json",
3+
"apiFile": "./fixtures/emptyApi.ts",
4+
"outputFile": "./tmp/example.ts"
5+
}

0 commit comments

Comments
 (0)