Skip to content

Commit 48f52e0

Browse files
committed
Remove time-sensitive CI test
1 parent c887f6c commit 48f52e0

File tree

3 files changed

+19
-18
lines changed

3 files changed

+19
-18
lines changed

packages/toolkit/src/query/core/buildThunks.ts

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -356,26 +356,33 @@ export function buildThunks<
356356
let catchedError = error
357357
if (catchedError instanceof HandledError) {
358358
let transformErrorResponse: (
359-
baseQueryReturnValue: any,
360-
meta: any,
361-
arg: any
359+
baseQueryReturnValue: any,
360+
meta: any,
361+
arg: any
362362
) => any = defaultTransformResponse
363363

364-
if (endpointDefinition.query && endpointDefinition.transformErrorResponse) {
364+
if (
365+
endpointDefinition.query &&
366+
endpointDefinition.transformErrorResponse
367+
) {
365368
transformErrorResponse = endpointDefinition.transformErrorResponse
366369
}
367370
try {
368371
return rejectWithValue(
369-
await transformErrorResponse(catchedError.value, catchedError.meta, arg.originalArgs),
370-
{ baseQueryMeta: catchedError.meta }
372+
await transformErrorResponse(
373+
catchedError.value,
374+
catchedError.meta,
375+
arg.originalArgs
376+
),
377+
{ baseQueryMeta: catchedError.meta }
371378
)
372379
} catch (e) {
373380
catchedError = e
374381
}
375382
}
376383
if (
377384
typeof process !== 'undefined' &&
378-
process.env.NODE_ENV === 'development'
385+
process.env.NODE_ENV !== 'production'
379386
) {
380387
console.error(
381388
`An unhandled error occurred processing a request for the endpoint "${arg.endpointName}".

packages/toolkit/src/query/tests/cleanup.test.tsx

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -177,8 +177,6 @@ test('Minimizes the number of subscription dispatches when multiple components a
177177
return <>{listItems}</>
178178
}
179179

180-
const start = Date.now()
181-
182180
render(<ParentComponent />, {
183181
wrapper: storeRef.wrapper,
184182
})
@@ -189,10 +187,6 @@ test('Minimizes the number of subscription dispatches when multiple components a
189187
return screen.getAllByText(/42/).length > 0
190188
})
191189

192-
const end = Date.now()
193-
194-
const timeElapsed = end - start
195-
196190
const subscriptions = getSubscriptionsA()
197191

198192
expect(Object.keys(subscriptions!).length).toBe(NUM_LIST_ITEMS)
@@ -203,7 +197,4 @@ test('Minimizes the number of subscription dispatches when multiple components a
203197
// 'api/executeQuery/fulfilled'
204198
// ]
205199
expect(actionTypes.length).toBe(4)
206-
// Could be flaky in CI, but we'll see.
207-
// Currently seeing 1000ms in local dev, 6300 without the batching fixes
208-
expect(timeElapsed).toBeLessThan(2500)
209200
}, 25000)

packages/toolkit/src/query/tests/devWarnings.test.tsx

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -346,8 +346,11 @@ In the case of an unhandled error, no tags will be "provided" or "invalidated".
346346
return { error: {} }
347347
},
348348
endpoints: (build) => ({
349-
transformErRspn: build.query<any, void>({
350-
query() {},
349+
// @ts-ignore TS doesn't like `() => never` for `tER`
350+
transformErRspn: build.query<number, void>({
351+
// @ts-ignore TS doesn't like `() => never` for `tER`
352+
query: () => '/dummy',
353+
// @ts-ignore TS doesn't like `() => never` for `tER`
351354
transformErrorResponse() {
352355
throw new Error('this was kinda expected')
353356
},

0 commit comments

Comments
 (0)