Handle errors thrown by listeners

Author: markerikson

packages/action-listener-middleware/src/index.ts

@@ -249,11 +249,15 @@ export function createActionListenerMiddleware<
           continue
         }
 
-        entry.listener(action, {
-          ...api,
-          currentPhase,
-          unsubscribe: entry.unsubscribe,
-        })
+        try {
+          entry.listener(action, {
+            ...api,
+            currentPhase,
+            unsubscribe: entry.unsubscribe,
+          })
+        } catch (err) {
+          // ignore
+        }
       }
       if (currentPhase === 'beforeReducer') {
         result = next(action)

packages/action-listener-middleware/src/tests/listenerMiddleware.test.ts

@@ -298,4 +298,18 @@ describe('createActionListenerMiddleware', () => {
 
     expect(reducer.mock.calls).toEqual([[{}, testAction1('a')]])
   })
+
+  test('Continues running other listeners if there is an error', () => {
+    const matcher = (action: any) => true
+
+    middleware.addListener(matcher, () => {
+      throw new Error('Panic!')
+    })
+
+    const listener = jest.fn(() => {})
+    middleware.addListener(matcher, listener)
+
+    store.dispatch(testAction1('a'))
+    expect(listener.mock.calls).toEqual([[testAction1('a'), middlewareApi]])
+  })
 })