Skip to content

Commit d1f44fe

Browse files
committed
fix selectors
1 parent e0a4203 commit d1f44fe

File tree

4 files changed

+17
-19
lines changed

4 files changed

+17
-19
lines changed

tests/e2e/src/page-objects/components/editor-view/DoubleColumnKeyDetailsView.ts

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,8 @@ export class DoubleColumnKeyDetailsView extends KeyDetailsView {
1313
By.xpath(
1414
`//*[contains(@data-testid, "edit-${keyType}-button-${name}")] | //*[contains(@data-testid, "${keyType}_edit-btn-${name}")]`,
1515
)
16-
getWrapperOfValueInput = (keyType: string, name: string): By =>
17-
By.xpath(
18-
`//*[contains(@data-testid, "${keyType}_content-${name}")]/parent::*`,
19-
)
16+
getWrapperOfValueInput = (keyType: string, name: string): By =>
17+
By.xpath(`//*[contains(@data-testid, "${keyType}_content-value-${name}")]/parent::*`)
2018

2119
/**
2220
* Edit key value from details
@@ -31,10 +29,7 @@ export class DoubleColumnKeyDetailsView extends KeyDetailsView {
3129
editorLocator: By,
3230
keyType: string,
3331
): Promise<void> {
34-
await InputActions.hoverElement(
35-
this.getWrapperOfValueInput(keyType, name),
36-
1000,
37-
)
32+
await InputActions.hoverElement(this.getWrapperOfValueInput(keyType, name),1000)
3833
const editLocator = this.getEditButton(keyType, name)
3934
await ButtonActions.clickElement(editLocator)
4035
await InputActions.typeText(editorLocator, value)
@@ -54,10 +49,7 @@ export class DoubleColumnKeyDetailsView extends KeyDetailsView {
5449
editorLocator: By,
5550
keyType: string,
5651
): Promise<void> {
57-
await InputActions.hoverElement(
58-
this.getWrapperOfValueInput(keyType, name),
59-
1000,
60-
)
52+
await InputActions.hoverElement(this.getWrapperOfValueInput(keyType, name),1000)
6153
const editLocator = this.getEditButton(keyType, name)
6254
await ButtonActions.clickElement(editLocator)
6355
await InputActions.slowType(editorLocator, value)

tests/e2e/src/page-objects/components/tree-view/TreeView.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,7 @@ export class TreeView extends WebView {
261261
)
262262
await ButtonActions.clickElement(this.keyTreeFilterApplyBtn)
263263
await this.waitForElementVisibility(this.loadingIndicator, 2000, true)
264-
await this.waitForElementVisibility(this.loadingIndicator, 3000, false)
264+
await this.waitForElementVisibility(this.loadingIndicator, 5000, false)
265265
}
266266

267267
/**

tests/e2e/src/tests/browser/filtering.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -429,7 +429,7 @@ describe('Filtering per key name in DB with 10 millions of keys', () => {
429429
// Verify that all results have the same type as in filter
430430
expect(
431431
await treeView.getElementText(treeView.getTreeViewItemByIndex(i + 1)),
432-
).contains(keyTypes[i].keyName, 'Keys filtered incorrectly by key type')
432+
).contains(keyTypes[i].keyName, 'Keys filtered incorrectly by key type after scanning more')
433433
}
434434
})
435435
})

tests/e2e/src/tests/browser/formatters.ts

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -521,10 +521,7 @@ describe('Formatters', () => {
521521
await keyDetailsView.selectFormatter(formatter.format)
522522
await CommonDriverExtension.driverSleep(300)
523523
// Hover over value to see edit button for hash and list
524-
if (
525-
key.keyType === KeyTypesShort.Hash ||
526-
key.keyType === KeyTypesShort.List
527-
) {
524+
if (key.keyType === KeyTypesShort.Hash) {
528525
await InputActions.hoverElement(
529526
doubleColumnKeyDetailsView.getWrapperOfValueInput(
530527
key.keyType,
@@ -533,6 +530,15 @@ describe('Formatters', () => {
533530
1000,
534531
)
535532
}
533+
if (key.keyType === KeyTypesShort.List) {
534+
await InputActions.hoverElement(
535+
doubleColumnKeyDetailsView.getWrapperOfValueInput(
536+
key.keyType,
537+
'0',
538+
),
539+
1000,
540+
)
541+
}
536542
// Verify that edit button disabled for Hash, List, String keys
537543
expect(await keyDetailsView.isElementDisabled(editBtn, 'class')).eql(
538544
true,
@@ -553,7 +559,7 @@ describe('Formatters', () => {
553559
await InputActions.hoverElement(
554560
doubleColumnKeyDetailsView.getWrapperOfValueInput(
555561
key.keyType,
556-
value,
562+
'0',
557563
),
558564
1000,
559565
)

0 commit comments

Comments
 (0)