Skip to content

Commit bb26354

Browse files
committed
Merge branch 'main' into feature/remove_packages
2 parents 55c7bf7 + dbf5e07 commit bb26354

37 files changed

+75
-54
lines changed

.circleci/config.yml

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,6 @@ executors:
4848
machine:
4949
image: ubuntu-2004:2023.04.2
5050
docker_layer_caching: true
51-
environment:
52-
DISPLAY: ":99"
5351
docker-node:
5452
docker:
5553
- image: cimg/node:20.15
@@ -91,7 +89,7 @@ jobs:
9189
paths:
9290
- ~/.cache/yarn
9391

94-
e2e-app-image:
92+
e2e-linux:
9593
executor: linux-executor-dlc
9694
parameters:
9795
report:
@@ -116,10 +114,22 @@ jobs:
116114
command: |
117115
sudo apt-get install -y xvfb
118116
Xvfb :99 -screen 0 1920x1080x24 &
117+
- run:
118+
name: Install dependencies
119+
command: cd tests/e2e && yarn install
120+
- run:
121+
name: Compile TypeScript
122+
command: cd tests/e2e && yarn compile
123+
- run:
124+
name: Verify Compiled Files
125+
command: ls -R tests/e2e/dist/tests/
119126
- run:
120127
name: Run e2e tests
121128
command: |
122-
cd tests/e2e && export TEST_FILES=$(circleci tests glob "tests/**/*.e2e.ts" | circleci tests split --split-by=timings) && cd ../..
129+
cd tests/e2e/dist
130+
export TEST_FILES=$(circleci tests glob "tests/**/*.e2e.js" | circleci tests split --split-by=timings)
131+
echo "Running tests: $TEST_FILES"
132+
cd ../../..
123133
.circleci/e2e/test.app.sh
124134
- when:
125135
condition:
@@ -402,7 +412,7 @@ workflows:
402412
requires:
403413
- Start E2E Tests
404414

405-
- e2e-app-image:
415+
- e2e-linux:
406416
name: E2ETest (linux)
407417
parallelism: 2
408418
requires:
@@ -511,7 +521,7 @@ workflows:
511521
name: Build extension - Windows (stage)
512522
<<: *stageFilter
513523
# e2e tests on linux build
514-
- e2e-app-image:
524+
- e2e-linux:
515525
name: E2ETest (linux)
516526
parallelism: 2
517527
requires:
@@ -549,7 +559,7 @@ workflows:
549559
<<: *prodFilter
550560

551561
# e2e tests on linux build
552-
- e2e-app-image:
562+
- e2e-linux:
553563
name: E2ETest (Linux)
554564
parallelism: 2
555565
requires:

.circleci/e2e/test.app.sh

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,14 @@
11
#!/bin/bash
22
set -e
33

4-
yarn --cwd tests/e2e install
5-
6-
# create folder before tests run to prevent permissions issue
4+
# Create folder before tests run to prevent permissions issues
75
mkdir -p tests/e2e/remote
86

9-
# run rte
7+
# Run RTE (Redis Test Environment)
108
docker-compose -f tests/e2e/rte.docker-compose.yml build
119
docker-compose -f tests/e2e/rte.docker-compose.yml up --force-recreate -d -V
12-
./tests/e2e/wait-for-redis.sh localhost 12000 && \
10+
./tests/e2e/wait-for-redis.sh localhost 12000
1311

14-
# run tests
12+
# Run tests
1513
RI_SOCKETS_CORS=true \
1614
yarn --cwd tests/e2e dotenv -e .ci.env yarn --cwd tests/e2e test:ci

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ For more details, check out the [release notes](https://github.com/RedisInsight/
1515

1616
## Get started with Redis for VS Code
1717

18-
This repository contains the source code for the Redis for VS Code extension. To start using the extension, install it from the [Visual Studio Code Marketplace](https://marketplace.visualstudio.com/vscode).
18+
This repository contains the source code for the Redis for VS Code extension. Install the extension from the [Visual Studio Code Marketplace](https://marketplace.visualstudio.com/items?itemName=redis.redis-for-vscode).
1919

2020
## Feedback
2121

tests/e2e/.ci.env

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
COMMON_URL=http://localhost:5541
21
API_URL=http://127.0.0.1:5541/api
32
OSS_SENTINEL_PASSWORD=password
43
RI_APP_FOLDER_NAME=.redis-for-vscode-stage

tests/e2e/.mocharc.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ module.exports = {
44
color: true,
55
delay: false,
66
diff: true,
7-
file: ['./tests/setup.js'],
87
package: './package.json',
98
parallel: false,
109
recursive: false,
@@ -20,7 +19,7 @@ module.exports = {
2019
toConsole: false,
2120
},
2221
},
23-
retries: 1,
22+
retries: 3,
2423
timeout: 100_000,
2524
ui: 'bdd',
2625
}

tests/e2e/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
"ts-node": "10.9.1",
4444
"tsc-alias": "^1.8.8",
4545
"typescript": "^5.1.3",
46-
"vscode-extension-tester": "^8.5.0"
46+
"vscode-extension-tester": "^8.6.0"
4747
},
4848
"dependencies": {
4949
"clone-deep": "^4.0.1",

tests/e2e/settings.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@
33
"workbench.editor.enablePreview": true,
44
"git.autoRepositoryDetection": false,
55
"terminal.integrated.sendKeybindingsToShell": true
6-
}
6+
}

tests/e2e/src/helpers/Conf.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import { Chance } from 'chance'
55
const chance = new Chance()
66

77
export class Config {
8-
static commonUrl = process.env.COMMON_URL || 'http://localhost:8080'
98
static apiUrl = process.env.API_URL || 'http://127.0.0.1:5541/api'
109
static vscodeVersion = process.env.VSCODE_VERSION || '1.87.2'
1110
static extensionName =

tests/e2e/src/tests/browser/filtering.ts renamed to tests/e2e/src/tests/browser/filtering.e2e.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -428,7 +428,7 @@ describe('Filtering per key name in DB with 10 millions of keys', () => {
428428
for (let i = 0; i < keyTypes.length - 1; i++) {
429429
await treeView.selectFilterGroupType(keyTypes[i].keyName)
430430
// Waiting for long db loading
431-
CommonDriverExtension.driverSleep(2000)
431+
CommonDriverExtension.driverSleep(3000)
432432
// Verify that all results have the same type as in filter
433433
expect(
434434
await treeView.getElementText(treeView.getTreeViewItemByIndex(i + 1)),
File renamed without changes.

tests/e2e/src/tests/setup.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,6 @@ describe('Agreements Verification', () => {
4343
await eulaView.switchToInnerViewFrame(InnerViews.EulaInnerView)
4444
await eulaView.waitForElementVisibility(eulaView.submitButton)
4545
})
46-
after(async () => {
47-
await treeView.switchBack()
48-
})
4946
afterEach(async () => {
5047
await treeView.switchBack()
5148
})

tests/e2e/src/vscode.runner.ts

Lines changed: 23 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,12 +56,31 @@ import { VScodeScripts } from './helpers/scripts/vscodeScripts'
5656
})
5757
}
5858

59+
let testFilesEnv: string | string[] = process.env.TEST_FILES!
60+
if (process.env.TEST_FILES) {
61+
testFilesEnv = process.env.TEST_FILES.split('\n').map(file => file.trim()).map((file) => {
62+
return path.join(__dirname, '..', 'dist', file)
63+
})
64+
65+
// Always prepend setup.js
66+
const setupTestPath = path.join(
67+
__dirname,
68+
'..',
69+
'dist',
70+
'tests',
71+
'setup.js',
72+
)
73+
testFilesEnv.unshift(setupTestPath)
74+
75+
console.log('Full Paths:', testFilesEnv)
76+
} else {
77+
console.error('TEST_FILES environment variable is not defined.')
78+
}
79+
5980
// Run tests
6081
await exTester.runTests(
61-
[
62-
path.join(__dirname, '..', 'dist', 'tests', 'setup.js'),
63-
path.join(__dirname, '..', 'dist', 'tests', '**', '*.js'),
64-
],
82+
testFilesEnv ||
83+
path.join(__dirname, '..', 'dist', 'tests', '**', '*.e2e.js'),
6584
{
6685
settings: 'settings.json',
6786
logLevel: logging.Level.INFO,

tests/e2e/yarn.lock

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -268,15 +268,15 @@
268268
resolved "https://registry.yarnpkg.com/@pkgjs/parseargs/-/parseargs-0.11.0.tgz#a77ea742fab25775145434eb1d2328cf5013ac33"
269269
integrity sha512-+1VkjdD0QBLPodGrJUeqarH8VAIvQODIbwh9XpP5Syisf7YoQgsJKPNFoqqLQlu+VQ/tVSshMR6loPMn8U+dPg==
270270

271-
"@redhat-developer/locators@^1.3.0":
272-
version "1.3.0"
273-
resolved "https://registry.yarnpkg.com/@redhat-developer/locators/-/locators-1.3.0.tgz#d15c0da18489cea44cc802f00013518e40da3941"
274-
integrity sha512-dY8vNdAxFCX0Bl1/9rcSgQKeglI2H5XyCXPMPjyo517Fi2+lPLibonRdZS7imrwVCRkkXShf0A4qK1sGi7PI6g==
271+
"@redhat-developer/locators@^1.4.0":
272+
version "1.4.0"
273+
resolved "https://registry.yarnpkg.com/@redhat-developer/locators/-/locators-1.4.0.tgz#dfce161a95eb37e9092f30ac6ef5fe148472ccf7"
274+
integrity sha512-RCWkhduNC88vem9jxkoZRFi/tCNl5pTB3tyWTXQ5wA3y3+jSHdxXveN7xMBr3kFlmNUiFiU9AuW3VuwDNj2fpw==
275275

276-
"@redhat-developer/page-objects@^1.3.0":
277-
version "1.3.0"
278-
resolved "https://registry.yarnpkg.com/@redhat-developer/page-objects/-/page-objects-1.3.0.tgz#0bd24b273671f16509f532dac1f334b5f180313b"
279-
integrity sha512-sTpiGyEnNRvJtZpJWgbz/K3qVWdqv67/KJhIQdRCOUbPuqYfk3ouF/Lxu+qVvHLhlPbgUPd6hz2Jtw1XyqSSZA==
276+
"@redhat-developer/page-objects@^1.4.0":
277+
version "1.4.0"
278+
resolved "https://registry.yarnpkg.com/@redhat-developer/page-objects/-/page-objects-1.4.0.tgz#60bc31413fa774b06172a243fde7fceb2f9885ee"
279+
integrity sha512-/JDSnxIsxde275pBIlsZdPKh5u9XR/oKrG2ArV4IGFfyC1IfcLjCwcFpj708lcahXF8OTHlmh+1jTcsenpb+sg==
280280
dependencies:
281281
clipboardy "^4.0.0"
282282
clone-deep "^4.0.1"
@@ -442,10 +442,10 @@
442442
dependencies:
443443
redis "*"
444444

445-
"@types/selenium-webdriver@^4.1.24":
446-
version "4.1.25"
447-
resolved "https://registry.yarnpkg.com/@types/selenium-webdriver/-/selenium-webdriver-4.1.25.tgz#9f04cbe716529f74b3d86a445c000aedec7813a6"
448-
integrity sha512-Jnlg7h7WDq4k8N2p/zp1ax6qizvU9Pn37I/HR/KX8k5TIU1wfUAuBy8CA6x8drAqa9PY3kYykmmyNHU4tX91LQ==
445+
"@types/selenium-webdriver@^4.1.25":
446+
version "4.1.26"
447+
resolved "https://registry.yarnpkg.com/@types/selenium-webdriver/-/selenium-webdriver-4.1.26.tgz#09c696a341cf8cfc1641cded11d14813350b6ca9"
448+
integrity sha512-PUgqsyNffal0eAU0bzGlh37MJo558aporAPZoKqBeB/pF7zhKl1S3zqza0GpwFqgoigNxWhEIJzru75eeYco/w==
449449
dependencies:
450450
"@types/node" "*"
451451
"@types/ws" "*"
@@ -627,10 +627,10 @@
627627
"@vscode/vsce-sign-win32-arm64" "2.0.2"
628628
"@vscode/vsce-sign-win32-x64" "2.0.2"
629629

630-
"@vscode/vsce@^2.31.1":
631-
version "2.31.1"
632-
resolved "https://registry.yarnpkg.com/@vscode/vsce/-/vsce-2.31.1.tgz#2420167e5b5ac49ff8fd1aeebfadde43711fbe55"
633-
integrity sha512-LwEQFKXV21C4/brvGPH/9+7ZOUM5cbK7oJ4fVmy0YG75NIy1HV8eMSoBZrl+u23NxpAhor62Cu1aI+JFtCtjSg==
630+
"@vscode/vsce@^3.0.0":
631+
version "3.0.0"
632+
resolved "https://registry.yarnpkg.com/@vscode/vsce/-/vsce-3.0.0.tgz#79fa4a263eb9477d49efb2931d45204e3efbcb78"
633+
integrity sha512-UKYcC7fcSw6AUK6nlfm8A8WSOA41H3DRAwafCMp9CQpg3K9COAQKkrgQ+dKPhwkFTP7SPZNEiulDpPLwvr5QQQ==
634634
dependencies:
635635
"@azure/identity" "^4.1.0"
636636
"@vscode/vsce-sign" "^2.0.0"
@@ -3735,7 +3735,7 @@ universalify@^2.0.0:
37353735
resolved "https://registry.yarnpkg.com/universalify/-/universalify-2.0.1.tgz#168efc2180964e6386d061e094df61afe239b18d"
37363736
integrity sha512-gptHNQghINnc/vTGIk0SOFGFNXw7JVrlRUtConJRlvaw6DuX0wO5Jeko9sWrMBhh+PsYAZ7oXAiOnf/UKogyiw==
37373737

3738-
unzipper@^0.12.2:
3738+
unzipper@^0.12.3:
37393739
version "0.12.3"
37403740
resolved "https://registry.yarnpkg.com/unzipper/-/unzipper-0.12.3.tgz#31958f5eed7368ed8f57deae547e5a673e984f87"
37413741
integrity sha512-PZ8hTS+AqcGxsaQntl3IRBw65QrBI6lxzqDEL7IAo/XCEqRTKGfOX56Vea5TH9SZczRVxuzk1re04z/YjuYCJA==
@@ -3797,15 +3797,15 @@ validator@^13.6.0:
37973797
resolved "https://registry.yarnpkg.com/validator/-/validator-13.11.0.tgz#23ab3fd59290c61248364eabf4067f04955fbb1b"
37983798
integrity sha512-Ii+sehpSfZy+At5nPdnyMhx78fEoPDkR2XW/zimHEL3MyGJQOCQ7WeP20jPYRz7ZCpcKLB21NxuXHF3bxjStBQ==
37993799

3800-
vscode-extension-tester@^8.5.0:
3801-
version "8.5.0"
3802-
resolved "https://registry.yarnpkg.com/vscode-extension-tester/-/vscode-extension-tester-8.5.0.tgz#7c8ad6e4790736678169c9da5b4d9f04c1d16f89"
3803-
integrity sha512-b4O53LQlBC6ZcQNzmkcBW5AhG/cD+odNpIPqNTMhDx7JIBgCq2fyJLLxNl9tDMDn05rqCHeXEOiwuReijlnz0g==
3800+
vscode-extension-tester@^8.6.0:
3801+
version "8.6.0"
3802+
resolved "https://registry.yarnpkg.com/vscode-extension-tester/-/vscode-extension-tester-8.6.0.tgz#d759d8dfb87f4fec3026a7f2b2a9cad9a22a89e3"
3803+
integrity sha512-7h1Hi4IcH7HokofFaEFC0/h1BlF7h6iZSKkNeOezv01lZMCBP3NSDy+3YP6oyT91D90g0L0iuiTduThfcwFcag==
38043804
dependencies:
3805-
"@redhat-developer/locators" "^1.3.0"
3806-
"@redhat-developer/page-objects" "^1.3.0"
3807-
"@types/selenium-webdriver" "^4.1.24"
3808-
"@vscode/vsce" "^2.31.1"
3805+
"@redhat-developer/locators" "^1.4.0"
3806+
"@redhat-developer/page-objects" "^1.4.0"
3807+
"@types/selenium-webdriver" "^4.1.25"
3808+
"@vscode/vsce" "^3.0.0"
38093809
c8 "^10.1.2"
38103810
commander "^12.1.0"
38113811
compare-versions "^6.1.1"
@@ -3818,7 +3818,7 @@ vscode-extension-tester@^8.5.0:
38183818
sanitize-filename "^1.6.3"
38193819
selenium-webdriver "^4.23.0"
38203820
targz "^1.0.1"
3821-
unzipper "^0.12.2"
3821+
unzipper "^0.12.3"
38223822

38233823
which@^2.0.1:
38243824
version "2.0.2"

0 commit comments

Comments
 (0)