RI-6931: Require login on every free cloud db creation (#260)

* introduce a REQUIRE_LOGIN_ON_NEW_DB constant, as there is no logout functionality and the user should be able to create free DBs with different accounts
* modify existing test and add new ones depending on the REQUIRE_LOGIN_ON_NEW_DB value

Author: dantovska

src/webviews/src/modules/oauth/oauth-sso/oauth-create-db/OAuthCreateDb.spec.tsx

@@ -8,6 +8,7 @@ import { initialOAuthState, useOAuthStore } from 'uiSrc/store'
 import { INFINITE_MESSAGES } from 'uiSrc/components'
 import { act, cleanup, constants, fireEvent, render, screen } from 'testSrc/helpers'
 import OAuthCreateDb from './OAuthCreateDb'
+import { REQUIRE_LOGIN_ON_NEW_DB } from './constants'
 
 vi.spyOn(utils, 'sendEventTelemetry')
 vi.spyOn(utils, 'showInfinityToast')
@@ -85,18 +86,66 @@ describe('OAuthCreateDb', () => {
     })
   })
 
-  it('should render proper components if user is logged in', () => {
+  it('should call proper actions after click on sign button w/o recommended settings', async () => {
+    render(<OAuthCreateDb />)
+
+    await act(async () => {
+      fireEvent.click(screen.getByTestId('oauth-recommended-settings-checkbox'))
+    })
+
+    fireEvent.click(screen.getByTestId('google-oauth'))
+
+    expect(sendEventTelemetry).toBeCalledWith({
+      event: TelemetryEvent.CLOUD_SIGN_IN_SOCIAL_ACCOUNT_SELECTED,
+      eventData: {
+        accountOption: OAuthStrategy.Google,
+        action: OAuthSocialAction.Create,
+        cloudRecommendedSettings: 'disabled',
+      },
+    })
+
+    expect(useOAuthStore.getState().isOpenSocialDialog).toEqual(false)
+  })
+
+  it.skipIf(REQUIRE_LOGIN_ON_NEW_DB)('should render proper components when user is logged in', () => {
+    useOAuthStore.setState({ ...initialOAuthState,
+      agreement: true,
+      user: {
+        ...initialOAuthState.user,
+        data: {},
+      },
+    })
+
+    render(<OAuthCreateDb />)
+
+    expect(screen.getByTestId('oauth-advantages')).toBeInTheDocument()
+    expect(screen.getByTestId('oauth-recommended-settings-checkbox')).toBeInTheDocument()
+    expect(screen.getByTestId('oauth-create-db')).toBeInTheDocument()
+
+    expect(screen.queryByTestId('oauth-agreement-checkbox')).not.toBeInTheDocument()
+    expect(screen.queryByTestId('oauth-container-social-buttons')).not.toBeInTheDocument()
+  })
+
+  it.skipIf(!REQUIRE_LOGIN_ON_NEW_DB)('should render oauth form elements if user logged in', () => {
+    useOAuthStore.setState({ ...initialOAuthState,
+      agreement: true,
+      user: {
+        ...initialOAuthState.user,
+        data: {},
+      },
+    })
+
     render(<OAuthCreateDb />)
 
     expect(screen.getByTestId('oauth-advantages')).toBeInTheDocument()
-    // expect(screen.getByTestId('oauth-create-db')).toBeInTheDocument()
     expect(screen.getByTestId('oauth-recommended-settings-checkbox')).toBeInTheDocument()
+    expect(screen.getByTestId('oauth-agreement-checkbox')).toBeInTheDocument()
+    expect(screen.getByTestId('oauth-container-social-buttons')).toBeInTheDocument()
 
-    // expect(screen.queryByTestId('oauth-agreement-checkbox')).not.toBeInTheDocument()
-    // expect(screen.queryByTestId('oauth-container-social-buttons')).not.toBeInTheDocument()
+    expect(screen.queryByTestId('oauth-create-db')).not.toBeInTheDocument()
   })
 
-  it('should call proper actions after click create', async () => {
+  it.skipIf(REQUIRE_LOGIN_ON_NEW_DB)('should call proper actions after click create', async () => {
     const name = CloudJobName.CreateFreeSubscriptionAndDatabase
     useOAuthStore.setState({ ...initialOAuthState,
       agreement: true,
@@ -120,7 +169,7 @@ describe('OAuthCreateDb', () => {
     )
   })
 
-  it('should call proper actions after click create without recommened settings', async () => {
+  it.skipIf(REQUIRE_LOGIN_ON_NEW_DB)('should call proper actions after click create without recommened settings', async () => {
     useOAuthStore.setState({ ...initialOAuthState,
       agreement: true,
       source: 'source',

src/webviews/src/modules/oauth/oauth-sso/oauth-create-db/OAuthCreateDb.tsx

@@ -10,6 +10,7 @@ import { createFreeDbJob, fetchCloudSubscriptionPlans, useOAuthStore } from 'uiS
 import { Spacer } from 'uiSrc/ui'
 import { INFINITE_MESSAGES } from 'uiSrc/components'
 
+import { REQUIRE_LOGIN_ON_NEW_DB } from './constants'
 import { OAuthForm } from '../../shared/oauth-form'
 import OAuthAgreement from '../../shared/oauth-agreement/OAuthAgreement'
 import { OAuthAdvantages, OAuthRecommendedSettings } from '../../shared'
@@ -85,7 +86,7 @@ const OAuthCreateDb = (props: Props) => {
         <OAuthAdvantages />
       </div>
       <div className={styles.socialContainer}>
-        {!data ? (
+        {!data || REQUIRE_LOGIN_ON_NEW_DB ? (
           <OAuthForm
             className={styles.socialButtons}
             onClick={handleSocialButtonClick}

src/webviews/src/modules/oauth/oauth-sso/oauth-create-db/constants.ts

@@ -0,0 +1,4 @@
+// TODO [DA]: Remove once logout is implemented and it is decided that this functionality no longer needed
+// Added in order to give flexibility to the user to login every time and change cloud accounts
+// on each create free db event
+export const REQUIRE_LOGIN_ON_NEW_DB: boolean = true