Skip to content

Commit 26770a0

Browse files
committed
* #RIVS-238 - [Regression] 500 error when opening RI vscode extension in the 2nd vscode window
* #RIVS-246 - [Regression] Remove key icon overlaps 'Sorted Set' text * #RIVS-248 - Tooltips are not fully visible with small width * #RIVS-257 - [Regression] Database has been edited notification not displayed after editing connection
1 parent 180510d commit 26770a0

File tree

8 files changed

+15
-8
lines changed

8 files changed

+15
-8
lines changed

src/constants.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ export enum ViewId {
99
}
1010

1111
export const MAX_TITLE_KEY_LENGTH = 30
12-
export const EXTENSION_ID = 'redis.redis-insight-vsc-plugin'
12+
export const EXTENSION_ID = 'redis.redis-for-vscode'
1313

1414
export const EXTERNAL_LINKS = {
1515
releaseNotes: 'https://github.com/RedisInsight/RedisInsight/releases',

src/server/bootstrapBackend.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,14 @@ import * as fs from 'fs'
55
import { workspaceStateService } from '../lib'
66
import { CustomLogger } from '../logger'
77

8-
const appPort = process.env.RI_APP_PORT
9-
108
let gracefulShutdown: Function
119
let beApp: any
1210

1311
const backendPath = path.join(__dirname, '..', 'redis-backend/dist-minified')
1412

1513
export async function startBackend(logger: CustomLogger): Promise<any> {
14+
const appPort = process.env.RI_APP_PORT
15+
1616
const port = await (await getPort.default(+appPort!)).toString()
1717
logger.log(`Starting at port: ${port}`)
1818

src/webviews/src/modules/keys-tree/components/key-row-delete/styles.module.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
.container {
2-
@apply absolute right-3;
2+
@apply absolute right-0;
33
}
44

55
.trigger {

src/webviews/src/modules/keys-tree/components/key-row-type/styles.module.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,6 @@
77
font-size: 11px;
88
line-height: 24px;
99

10-
width: 84px;
11-
min-width: 84px;
10+
width: 88px;
11+
min-width: 88px;
1212
}

src/webviews/src/modules/keys-tree/components/keys-summary/KeysSummary.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,11 @@ export const KeysSummary = (props: Props) => {
7575
)} */}
7676

7777
<div className="flex pr-3.5">
78-
<Tooltip content={l10n.t('Sort by key names displayed')}>
78+
<Tooltip
79+
keepTooltipInside={false}
80+
content={l10n.t('Sort by key names displayed')}
81+
position="bottom right"
82+
>
7983
<VSCodeButton
8084
appearance="icon"
8185
onClick={changeSortHandle}

src/webviews/src/store/hooks/use-databases-store/useDatabasesStore.spec.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -275,6 +275,7 @@ describe('useDatabasesStore', () => {
275275

276276
expect(useDatabasesStore.getState().data).toEqual(checkRediStack([databases[1]]))
277277
expect(useDatabasesStore.getState().loading).toEqual(false)
278+
expect(utils.showInformationMessage).toBeCalledWith('Database has been edited')
278279
})
279280

280281
it('call showErrorMessage when fetch is fail', async () => {

src/webviews/src/store/hooks/use-databases-store/useDatabasesStore.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,7 @@ export const updateDatabase = ({ id, ...payload }: Partial<Database>, onSuccess?
159159
const { status } = await apiService.patch(`${ApiEndpoints.DATABASES}/${id}`, payload)
160160

161161
if (isStatusSuccessful(status)) {
162+
showInformationMessage(successMessages.EDITED_NEW_DATABASE(payload.name ?? '').title)
162163
fetchDatabases()
163164
onSuccess?.()
164165
}

src/webviews/src/ui/tooltip/Tooltip.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ export interface Props extends PopupProps {
1313

1414
export const Tooltip = (props: Props) => {
1515
const {
16+
keepTooltipInside = true,
1617
position = 'top center',
1718
title,
1819
children: childrenInit,
@@ -30,7 +31,7 @@ export const Tooltip = (props: Props) => {
3031

3132
return (
3233
<Popup
33-
keepTooltipInside
34+
keepTooltipInside={keepTooltipInside}
3435
position={position}
3536
on="hover"
3637
trigger={children as JSX.Element}

0 commit comments

Comments
 (0)