Skip to content

Adding Testing Farm as GitHub action to testing s2i-dotnetcore #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
May 8, 2025
Merged

Adding Testing Farm as GitHub action to testing s2i-dotnetcore #505

merged 14 commits into from
May 8, 2025

Conversation

phracek
Copy link
Contributor

@phracek phracek commented May 6, 2025

This pull request adds Testing Farm for testing s2i-dotnet container in upstream.

Let's test it with each pull request.

It adds also dependabot in case some action will move to the newest version.

This action is tested here: phracek#2

phracek added 4 commits May 6, 2025 14:26
@phracek
Add Testing Farm as GitHub Action to testing S2I-DOTNET container
bfc3420 
Also auto-merger bot is added in order to see
when the tests were executed and their results.

Also dependabot is added if some github actions are changed.

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek
Merge pull request #1 from phracek/add_testing_farm_as_github_action
29ef770 
Add Testing Farm as GitHub Action to testing S2I-DOTNET container
@phracek
Fix testing plan regex
2fec23b 
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek
Merge pull request #3 from phracek/fix_tmt_plan_name
0460e7f 
Fix testing plan regex
@phracek
Copy link
Contributor Author

phracek commented May 6, 2025

The tests in second pull request have passed phracek#2

@tmds tmds requested a review from omajid May 6, 2025 14:03
tmds
tmds reviewed May 6, 2025
View reviewed changes
tmds
tmds reviewed May 6, 2025
View reviewed changes
@phracek
Add more architectures to tests
1d7dec7 
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
tmds
tmds reviewed May 6, 2025
View reviewed changes
@phracek
Merge pull request #4 from phracek/add_arch
05c495b 
Add more architectures to tests
@tmds tmds requested review from aslicerh and nicrowe00 May 6, 2025 14:44
phracek added 2 commits May 6, 2025 16:45
@phracek
Add matrix arch to concurrency group
879dda8 
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek
Merge pull request #5 from phracek/add_concurency_group
6433681 
Add matrix arch to concurrency group
omajid
omajid reviewed May 6, 2025
View reviewed changes
omajid
omajid reviewed May 6, 2025
View reviewed changes
omajid
omajid reviewed May 6, 2025
View reviewed changes
phracek added 2 commits May 7, 2025 11:19
@phracek
Remove submodules from dependabot
7943d94 
Auto-merge support for "main" branch

Add more arcdhitecturs

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek
Merge pull request #6 from phracek/Add_more_architectures
713e491 
Remove submodules from dependabot
@phracek
Copy link
Contributor Author

phracek commented May 7, 2025

[test]

@phracek
Copy link
Contributor Author

phracek commented May 7, 2025

All combinations are running here phracek#2

@tmds
Copy link
Member

tmds commented May 7, 2025

All combinations are running here phracek#2

The failures on non-x64 may be due to trying to use the x64 s2i on those architectures.

If no s2i binary is provided on the host system, the build script from this repo should download one for the appropriate architecture.

@tmds
Copy link
Member

tmds commented May 7, 2025

These files seem to be about establishing an auto merge workflow: .github/auto-merge.yml, .github/workflows/auto-merge-on-demand.yml, .github/workflows/auto-merge.yml. Can we remove them? Or are they needed for the Testing Farm CI.

What is .github/workflows/pr-metadata.yml for? Can it be removed?

Can you remove the existing .github/workflows/ci.yml? This is a superset of what that covered.

@tmds
Copy link
Member

tmds commented May 7, 2025

[test]

tmds
tmds reviewed May 7, 2025
View reviewed changes
.github/workflows/testing-farm-tests.yml

if: |
github.event.issue.pull_request
&& contains(github.event.comment.body, '[test]')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the main reason for requiring a [test] message from an owner/member to prevent anyone from generating load on the Testing Farm?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used as soon as this PR is merged. [test] is used on main branch, where it does not exist.

tmds
tmds reviewed May 7, 2025
View reviewed changes
@phracek
Copy link
Contributor Author

phracek commented May 7, 2025

These files seem to be about establishing an auto merge workflow: .github/auto-merge.yml, .github/workflows/auto-merge-on-demand.yml, .github/workflows/auto-merge.yml. Can we remove them? Or are they needed for the Testing Farm CI.

They are not needed for Testing Farm CI.

@phracek
Remove auto-merge files. They are not needed for Testing Farm CI.
635cb2e 
Upstream does not need it.

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek
Copy link
Contributor Author

phracek commented May 7, 2025

All combinations are running here phracek#2

The failures on non-x64 may be due to trying to use the x64 s2i on those architectures.

If no s2i binary is provided on the host system, the build script from this repo should download one for the appropriate architecture.

Remove but this MR https://gitlab.cee.redhat.com/platform-eng-core-services/sclorg-tmt-plans/-/merge_requests/295

phracek added 3 commits May 7, 2025 14:45
@phracek
Merge pull request #7 from phracek/get_rid_off_auto_merge
2fd5ed2 
Remove auto-merge files. They are not needed for Testing Farm CI.
@phracek
Add new option --github-ci
571983d 
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek
Merge pull request #8 from phracek/add_option_github_ci
43b7e18 
Add new option --github-ci
@tmds
Copy link
Member

tmds commented May 8, 2025

@phracek thank you for implementing this, and dealing with all the feedback!

@omajid you can merge this when you've had a chance to look at the latest changes and they look good to you.

@omajid
Copy link
Member

omajid commented May 8, 2025

Thanks, @phracek !

@omajid omajid merged commit 4abf1a8 into redhat-developer:main May 8, 2025
@tmds
Copy link
Member

tmds commented May 9, 2025

I squashed these commits on main into 3d5b86c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@omajid omajid omajid left review comments

@tmds tmds tmds approved these changes

@aslicerh aslicerh Awaiting requested review from aslicerh

@nicrowe00 nicrowe00 Awaiting requested review from nicrowe00

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@phracek @tmds @omajid