LSP doesn't work for external dependencies (like jars)

[ericdallo]

When coding clojure-lsp integration with this plugin, I noticed that after you find the definition of a symbol that goes to a read only file of a external dependency, no LSP feature works on that opened file, no request besides textDocument/didOpen is sent to server.

Steps to reproduce in clojure-lsp:

1. Install the plugin + nightly lsp4ij build: clojure-lsp-2.6.4.zip (ref branch)
2. Open a clojure project, example: ericdallo/clojure-sample
3. Open a clojure file like foo.clj and wait for LSP initialize.
4. find definition of a function that belongs to a external lib, like concat or str from clojure.core.
5. the new file will be opened, but no LSP feature will work there, like find references or go to definition of local variables.

[angelozerr]

@ericdallo is it a blocker issue?

[angelozerr]

I suspect the problem comes from

lsp4ij/src/main/java/com/redhat/devtools/lsp4ij/LanguageServersRegistry.java

Line 563 in 06cfb21

if (file == null || !file.isInLocalFileSystem()) {

[ericdallo]

Yes, unfortunately it is @angelozerr, it's something really common in Clojure development

[ericdallo]

And I suspect this may happen for other languages like Java and Dart that have go to definition to external libs

[ericdallo]

I suspect the problem comes from

Yeah, that makes sense to me, IMO this inLocalSystem should not exists as the LSP protocol states that files could be even in remote system, not only local, although this jar problem is still considered local.

[angelozerr]

I did that to fix #560

[ericdallo]

Hum, looks like it's not the best way to fix it

[ericdallo]

Any chance we can have a flag or setting to not do that? also, removing that fixes the problem?

[angelozerr]

Any chance we can have a flag or setting to not do that? also, removing that fixes the problem?

Customize this behavior is my mind. I need to find time because I am super busy to clean the dap support to create a release.

If it is easy to do , I will try to do that but I cannot promise that.

[ericdallo]

Thanks, let me know if there is anything to help with, I'm interested in releasing this as soon as possible. We would need a release from lsp4ij as well

[ericdallo]

@angelozerr just to give you visibility, I built lsp4ij locally without that isInLocalFileSystem check and the issue fixes for me, although I know it was added because of #560, even so, I do think this check should not live there or jar files should be considered local as well.
I'm wondering if we could make it configurable by a setting/config or class we can extend to configure it, WDYT?