Skip to content

Commit 0df86d2

Browse files
Merge pull request #135 from lance/chapter-5-typos
Chapter 5 typos and corrections
2 parents 4f5206e + e504fbd commit 0df86d2

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

documentation/modules/ROOT/pages/05-build/build-templates.adoc

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@ The raw builds like what we did in xref:ROOT:05-build/build.adoc[previous chapte
55

66
* No reusability
77
* Hard coding of build parameters
8-
* Inability to make builds and services in synchronous i.e. services are deployed only after the related build is complete
8+
* Inability to make builds and services asynchronous i.e. services are deployed only after the related build is complete
99

1010
One of the solutions to these problems is **Build Templates**.
1111

12-
Similarly to the build spec, the Knative build template spec and the Knative service spec needs some customizations before being applied.
12+
Similar to the build spec, the Knative build template spec and the Knative service spec needs some customizations before being applied.
1313

1414
[#build-template-prerequisite]
1515
== Prerequisite
@@ -29,7 +29,7 @@ include::partial$prereq-cli.adoc[]
2929

3030
include::partial$build-nav-folder.adoc[]
3131

32-
For this chapters build template demos, we will be using the following Knative build template that will use maven to build the Java application. The build template leverages https://buildah.io[buildah] to build and push the container image based on the Java application built using maven.
32+
For this chapter's build template demos, we will be using the following Knative build template that will use maven to build the Java application. The build template leverages https://buildah.io[buildah] to build and push the container image based on the Java application built using maven.
3333

3434
[.text-center]
3535
.maven-build-template.yaml
@@ -52,7 +52,7 @@ spec:
5252
- "/usr/local/bin/buildah.sh"
5353
env:
5454
- name: WORK_DIR
55-
value: /workspace/${CONTEXT_DIR}
55+
value: ${CONTEXT_DIR}
5656
- name: DESTINATION_NAME
5757
value: ${IMAGE}
5858
# uncomment this if you have MAVEN_MIRROR thats is reachable from your kube cluster
@@ -70,7 +70,7 @@ spec:
7070
name: m2-cache
7171
- mountPath: /var/lib/containers
7272
name: container-storage
73-
workingDir: /workspace/${CONTEXT_DIR}
73+
workingDir: ${CONTEXT_DIR}
7474
timeout: 60m
7575
volumes:
7676
- name: m2-cache
@@ -122,13 +122,13 @@ spec:
122122
source:
123123
git:
124124
revision: v0.0.2 # <1>
125-
url: https://github.com/redhat-developer-demos/knative-tutorial-event-greeter.git
125+
url: https://github.com/redhat-developer-demos/knative-tutorial-greeter.git
126126
template:
127127
arguments: # <2>
128128
- name: IMAGE
129129
value: docker.io/demo/event-greeter:0.0.2
130130
- name: CONTEXT_DIR
131-
value: java/quarkus
131+
value: /workspace/java/quarkus
132132
name: build-java-maven # <3>
133133
timeout: 20m
134134
revisionTemplate:
@@ -137,7 +137,7 @@ spec:
137137
app: event-greeter
138138
spec:
139139
container:
140-
image: docker.io/kameshsampath/event-greeter:0.0.2
140+
image: docker.io/demo/event-greeter:0.0.2
141141
----
142142

143143
<1> Using another branch from the sources, just to differentiate the image produced by this build
@@ -222,6 +222,7 @@ include::ROOT:partial$invoke-service.adoc[tag=env]
222222
----
223223
http POST $IP_ADDRESS \
224224
'Host:event-greeter.{tutorial-namespace}.example.com' \
225+
'Accept:*/*' \
225226
message="test message"
226227
----
227228
copyToClipboard::build-template-invoke-svc[]

documentation/modules/ROOT/pages/05-build/build.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,7 @@ include::ROOT:partial$invoke-service.adoc[tag=env]
333333
[#build-run-service-call]
334334
[source,bash,subs="+macros,+attributes",linenums]
335335
----
336-
http POST $IP_ADDRESS \
336+
http POST $IP_ADDRESS 'Accept:*/*' \
337337
'Host:event-greeter.{tutorial-namespace}.example.com' \
338338
message="test message"
339339
----

0 commit comments

Comments
 (0)