Skip to content

Commit 0dc4c34

Browse files
authored
Do not sync okta users who are not ACTIVE (#163)
1 parent afa9502 commit 0dc4c34

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

pkg/syncer/okta.go

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ var (
3131
const (
3232
// API token given by Okta application
3333
secretOktaTokenKey = "okta-api-token"
34+
activeStatus = "ACTIVE"
3435
)
3536

3637
type OktaSyncer struct {
@@ -158,13 +159,15 @@ func (o *OktaSyncer) Sync() ([]userv1.Group, error) {
158159
users := o.cachedGroupMembers[cachedGroup.Id]
159160
for _, user := range users {
160161
profile := *user.Profile
161-
if userName, ok := profile[o.Provider.ProfileKey].(string); !ok {
162-
oktaLogger.Info("attribute unavailable on okta user profile " + o.Provider.ProfileKey)
163-
} else if o.Provider.ExtractLoginUsername {
164-
userName = strings.Split(userName, "@")[0]
165-
ocpGroup.Users = append(ocpGroup.Users, userName)
166-
} else {
167-
ocpGroup.Users = append(ocpGroup.Users, userName)
162+
if user.Status == activeStatus {
163+
if userName, ok := profile[o.Provider.ProfileKey].(string); !ok {
164+
oktaLogger.Info("attribute unavailable on okta user profile " + o.Provider.ProfileKey)
165+
} else if o.Provider.ExtractLoginUsername {
166+
userName = strings.Split(userName, "@")[0]
167+
ocpGroup.Users = append(ocpGroup.Users, userName)
168+
} else {
169+
ocpGroup.Users = append(ocpGroup.Users, userName)
170+
}
168171
}
169172
}
170173
ocpGroups = append(ocpGroups, ocpGroup)

0 commit comments

Comments
 (0)