Detector: Strict code

Author: jakubboucek

src/Detector.php

@@ -37,7 +37,8 @@ class Detector
     public const MODE_FULL = self::MODE_ENABLER | self::MODE_SIMPLE;
 
 
-    private ?Enabler $enabler;
+    private Enabler $enabler;
+
     /** @var string[] */
     private array $ips = ['::1', '127.0.0.1'];
 
@@ -65,17 +66,19 @@ public function __construct(int $mode = self::MODE_SIMPLE, ?Enabler $enabler = n
             ]
         );
 
-        $this->enabler = $enabler;
+        if ($enabler) {
+            $this->enabler = $enabler;
+        }
     }
 
     public function hasEnabler(): bool
     {
-        return $this->enabler !== null;
+        return isset($this->enabler);
     }
 
     public function getEnabler(): Enabler
     {
-        if ($this->enabler === null) {
+        if (isset($this->enabler) === false) {
             throw new InconsistentEnablerModeException('Unable to get Enabler because Detector constructed without it');
         }
 

tests/DetectorTest.php

@@ -128,8 +128,6 @@ public function getSettedIpDataProvider(): array
 
     /**
      * @dataProvider getSettedIpDataProvider
-     * @param $testValue
-     * @param $expected
      */
     public function testSettedIp(array $setIp, $testValue, $expected): void
     {
@@ -158,8 +156,6 @@ public function getAddedIpDataProvider(): array
 
     /**
      * @dataProvider getAddedIpDataProvider
-     * @param $testValue
-     * @param $expected
      */
     public function testAddedIp(array $setIp, $testValue, $expected): void
     {
@@ -195,7 +191,7 @@ public function testEnabler($testValue): void
     public function testMissingEnablerMode(): void
     {
         Assert::exception(function () {
-            $detector = new Detector(Detector::MODE_FULL);
+            new Detector(Detector::MODE_FULL);
         }, InconsistentEnablerModeException::class);
     }
 
@@ -214,7 +210,7 @@ public function testMissingEnablerShortcut(): void
         }, InconsistentEnablerModeException::class);
     }
 
-    public function testPluginPrepend()
+    public function testPluginPrepend(): void
     {
         $detector = new Detector(0);
         $detector->prependPlugin(
@@ -229,7 +225,7 @@ public function __invoke(Detector $detector): ?bool
         $detector->isDebugMode();
     }
 
-    public function testPluginAppend()
+    public function testPluginAppend(): void
     {
         $detector = new Detector(0);
         $detector->appendPlugin(