[php 8.4] Add property hooks upgrade - optional rule

[TomasVotruba]

class Product {
-    private string $name;
-
-    public function getName(): string {
-        return $this->name;
-    }
-
-    public function setName(string $name): void {
-        $this->name = ucfirst($name);
-    }
+    public string $name {
+        get { return $this->name; }
+        set { $this->name = ucfirst($value); }
+    }
}

[calebdw]

Not only should the hooks be added, but the asymmetric visibility should be considered as well or you've just changed behaviour.

For example, if you have a protected property with a getter and no setter then it should look like:

class Product {
-    protected string $name;
-
-    public function getName(): string {
-        return $this->name;
-    }
+    public protected(set) string $name;
}

Note that in this case there is no actual need for the get hook because we're just returning the property directly (no other modifications to the property. Also, the visibility should be private(set) if the original property was private