Merge pull request #14 from DevFactory/release/multiple-quality-improvements-fix-3

Multiple quality improvements - pmd:InefficientStringBuffering, squid…

Author: realtime-framework

app/src/main/java/domains/Channel.java

@@ -10,7 +10,7 @@ public class Channel {
 
 	public Channel(String name) {
 		this.name = name;
-		this.messages = new ArrayList<Message>();
+		this.messages = new ArrayList<>();
 		this.unRead = 0;
 	}
 

app/src/main/java/handlers/OrtcHandler.java

@@ -60,7 +60,7 @@ public static void prepareClient(Context context, InterfaceRefresher rootView){
 		selfHandler = new OrtcHandler();
 		selfHandler.context = context;
         selfHandler.rootView = rootView;
-		selfHandler.messages = new HashMap<String, Channel>();
+		selfHandler.messages = new HashMap<>();
 
 		Ortc api = new Ortc();
 		OrtcFactory factory;

app/src/main/java/preferences/PreferencesManager.java

@@ -41,12 +41,12 @@ public List<String> loadChannels(){
         String channels = settings.getString(CHANNELS,null);
         if(channels == null)
         {
-            return new ArrayList<String>();
+            return new ArrayList<>();
         }
 
         String[] parts = channels.split(",");
 
-        List<String> list = new ArrayList<String>();
+        List<String> list = new ArrayList<>();
 
         for (String channel : parts) {
             list.add(channel);
@@ -59,7 +59,7 @@ public void saveChannels(List<String> channels){
         StringBuilder channelsString = new StringBuilder();
 
         for (String channel : channels) {
-            channelsString.append(channel + ",");
+            channelsString.append(channel).append(",");
         }
 
         e.putString(CHANNELS,channelsString.toString());