fix(core): fixes issue with factory bind lazily referencing its enhanced self

Author: josepot

packages/core/src/bind/connectFactoryObservable.test.tsx

@@ -9,6 +9,7 @@ import {
   merge,
   EMPTY,
   NEVER,
+  noop,
 } from "rxjs"
 import { renderHook, act as actHook } from "@testing-library/react-hooks"
 import {
@@ -830,6 +831,22 @@ describe("connectFactoryObservable", () => {
 
         subscription.unsubscribe()
       })
+
+      it("does not crash when the observable lazily references its enhanced self", () => {
+        const [, obs$] = bind(
+          (key: number) => defer(() => obs$(key)).pipe(take(1)),
+          (key) => key,
+        )
+
+        let error = null
+        obs$(1)
+          .subscribe(noop, (e: any) => {
+            error = e
+          })
+          .unsubscribe()
+
+        expect(error).toBeNull()
+      })
     })
   })
 })

packages/core/src/internal/share-latest.ts

@@ -50,7 +50,7 @@ const shareLatest = <T>(
         },
       )
       emitIfEmpty()
-      if (subscription.closed) subscription = null
+      if (subscription && subscription.closed) subscription = null
     } else {
       innerSub = subject.subscribe(subscriber)
       if (currentValue !== EMPTY_VALUE) {