types: make types compatible for React 18

josepot · josepot · commit 8c71bcf0861e · 2022-04-11T15:27:13.000+02:00
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -47,8 +47,8 @@
     "@testing-library/react": "^13.0.0",
     "@testing-library/react-hooks": "^8.0.0-alpha.1",
     "@types/jest": "^27.4.1",
-    "@types/react": "^17.0.43",
-    "@types/react-dom": "^17.0.14",
+    "@types/react": "^18.0.1",
+    "@types/react-dom": "^18.0.0",
     "babel-jest": "^27.5.1",
     "esbuild": "^0.14.31",
     "husky": ">=7.0.4",
@@ -66,6 +66,5 @@
   },
   "lint-staged": {
     "*.{js,jsx,ts,tsx,json,md}": "prettier --write"
-  },
-  "dependencies": {}
+  }
 }
diff --git a/packages/core/src/Subscribe.tsx b/packages/core/src/Subscribe.tsx
@@ -37,6 +37,7 @@ const Throw = () => {
  * @remarks This Component doesn't trigger any updates from the source$.
  */
 export const Subscribe: React.FC<{
+  children?: React.ReactNode | undefined
   source$?: Observable<any>
   fallback?: NonNullable<ReactNode> | null
 }> = ({ source$, children, fallback }) => {
diff --git a/packages/core/src/test-helpers/TestErrorBoundary.tsx b/packages/core/src/test-helpers/TestErrorBoundary.tsx
@@ -2,6 +2,7 @@ import { Component, ErrorInfo } from "react"
 
 export class TestErrorBoundary extends Component<
   {
+    children?: React.ReactNode | undefined
     onError: (error: Error, errorInfo: ErrorInfo) => void
   },
   {
diff --git a/packages/dom/src/batchUpdates.test.tsx b/packages/dom/src/batchUpdates.test.tsx
@@ -24,6 +24,7 @@ const [useLatestNumber, latestNumber$] = bind(
 
 class TestErrorBoundary extends Component<
   {
+    children?: React.ReactNode | undefined
     onError: (error: Error, errorInfo: ErrorInfo) => void
   },
   {

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@ import { Component, ErrorInfo } from "react"`
`2`	`2`
`3`	`3`	`export class TestErrorBoundary extends Component<`
`4`	`4`	`{`
	`5`	`+ children?: React.ReactNode \| undefined`
`5`	`6`	`onError: (error: Error, errorInfo: ErrorInfo) => void`
`6`	`7`	`},`
`7`	`8`	`{`
Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,7 @@ const [useLatestNumber, latestNumber$] = bind(`
`24`	`24`
`25`	`25`	`class TestErrorBoundary extends Component<`
`26`	`26`	`{`
	`27`	`+ children?: React.ReactNode \| undefined`
`27`	`28`	`onError: (error: Error, errorInfo: ErrorInfo) => void`
`28`	`29`	`},`
`29`	`30`	`{`