fix: Subscribe with async errors

Co-authored-by: Josep M Sobrepere <jm.sobrepere@gmail.com>

Author: voliva

packages/core/src/Subscribe.test.tsx

@@ -1,6 +1,6 @@
 import { state } from "@rx-state/core"
-import { render, screen, act } from "@testing-library/react"
-import React, { StrictMode, useState, useEffect } from "react"
+import { act, render, screen } from "@testing-library/react"
+import React, { StrictMode, useEffect, useState } from "react"
 import { defer, EMPTY, NEVER, Observable, of, startWith } from "rxjs"
 import { bind, RemoveSubscribe, Subscribe as OriginalSubscribe } from "./"
 import { TestErrorBoundary } from "./test-helpers/TestErrorBoundary"

packages/core/src/Subscribe.tsx

@@ -8,7 +8,7 @@ import React, {
   useContext,
 } from "react"
 import { Observable, Subscription } from "rxjs"
-import type { StateObservable } from "@rxstate/core"
+import type { StateObservable } from "@rx-state/core"
 
 const SubscriptionContext = createContext<
   ((src: StateObservable<any>) => void) | null

packages/core/src/useStateObservable.ts

@@ -1,11 +1,10 @@
-import { useRef, useState } from "react"
 import {
-  SUSPENSE,
   DefaultedStateObservable,
-  StateObservable,
   liftEffects,
+  StateObservable,
+  SUSPENSE,
 } from "@rx-state/core"
-import { EMPTY_VALUE } from "./internal/empty-value"
+import { useRef, useState } from "react"
 import useSyncExternalStore from "./internal/useSyncExternalStore"
 import { useSubscription } from "./Subscribe"
 
@@ -31,21 +30,11 @@ export const useStateObservable = <O, E>(
     }
 
     const gv: <T>() => Exclude<T, typeof SUSPENSE> = () => {
-      const src = callbackRef.current!.source$ as DefaultedStateObservable<O, E>
-
-      if (src.getRefCount() > 0 || src.getDefaultValue) return getValue(src)
-
-      if (!subscription) throw new Error("Missing Subscribe!")
-
-      let error = EMPTY_VALUE
-      subscription.add(
-        liftEffects()(src).subscribe({
-          error: (e) => {
-            error = e
-          },
-        }),
-      )
-      if (error !== EMPTY_VALUE) throw error
+      const src = callbackRef.current!.source$ as DefaultedStateObservable<O>
+      if (!src.getRefCount() && !src.getDefaultValue) {
+        if (!subscription) throw new Error("Missing Subscribe!")
+        subscription(src)
+      }
       return getValue(src)
     }