get_smart_drive_list()

[helpdesk-cubesix]

Dear,

We have updated our netgate firewall to 24.11 sinds then we get the following error.

HP Errors:
[02-Dec-2024 18:22:33 Europe/Amsterdam] PHP Fatal error: Uncaught Error: Call to undefined function get_smart_drive_list() in /root/scripts/pfsense_zbx.php:1151
Stack trace:
#0 /root/scripts/pfsense_zbx.php(1666): pfz_get_smart_status()
#1 {main}
thrown in /root/scripts/pfsense_zbx.php on line 1151
[02-Dec-2024 18:52:33 Europe/Amsterdam] PHP Fatal error: Uncaught Error: Call to undefined function get_smart_drive_list() in /root/scripts/pfsense_zbx.php:1151
Stack trace:
#0 /root/scripts/pfsense_zbx.php(1666): pfz_get_smart_status()
#1 {main}
thrown in /root/scripts/pfsense_zbx.php on line 1151
[02-Dec-2024 19:22:32 Europe/Amsterdam] PHP Fatal error: Uncaught Error: Call to undefined function get_smart_drive_list() in /root/scripts/pfsense_zbx.php:1151
Stack trace:
#0 /root/scripts/pfsense_zbx.php(1666): pfz_get_smart_status()
#1 {main}

Would it be possible if you can take a look at it?

Regards,
Stephan de Bot

[rbicelli]

Hello,
I don't have access to netgate appliances, so I can't debug this issue.
As workaround you can disable items related to SMART:

[helpdesk-cubesix]

Hi Ricardo, We can provide you access if you want? From: Riccardo ***@***.***> Sent: Tuesday, December 3, 2024 11:22 AM To: rbicelli/pfsense-zabbix-template ***@***.***> Cc: Helpdesk | Cubesix ***@***.***>; Author ***@***.***> Subject: Re: [rbicelli/pfsense-zabbix-template] get_smart_drive_list() (Issue #187) Hello, I don't have access to netgate appliances, so I can't debug this issue. As workaround you can disable items related to SMART: image.png (view on web)<https://github.com/user-attachments/assets/48505aed-6e47-4a63-8cd0-dcffe361fc23> — Reply to this email directly, view it on GitHub<#187 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BANJV7BO5JUNOKSBHYSJQAL2DWA4JAVCNFSM6AAAAABS5EW37CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJUGEZTEOBVHE>. You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>

[brezlord]

It's not just smart issue. There is more going on. See attached log from Netgate 4200.
PHP_errors.log

[helpdesk-cubesix]

Hi Riccardo, Probleem seems to be that get_smart_drive_list no linger exists and is replaced by get_drive_list. For now I have added the following to the function pfz_get_smart_status $filename = "/tmp/sysversion.json"; $sysVersion = json_decode(file_get_contents($filename), true); if ($sysVersion['installed_version'] >= '24.11') { $devs = get_drive_list(); } else { $devs = get_smart_drive_list(); } From: Riccardo ***@***.***> Sent: Tuesday, December 3, 2024 11:22 AM To: rbicelli/pfsense-zabbix-template ***@***.***> Cc: Helpdesk | Cubesix ***@***.***>; Author ***@***.***> Subject: Re: [rbicelli/pfsense-zabbix-template] get_smart_drive_list() (Issue #187) Hello, I don't have access to netgate appliances, so I can't debug this issue. As workaround you can disable items related to SMART: image.png (view on web)<https://github.com/user-attachments/assets/48505aed-6e47-4a63-8cd0-dcffe361fc23> — Reply to this email directly, view it on GitHub<#187 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BANJV7BO5JUNOKSBHYSJQAL2DWA4JAVCNFSM6AAAAABS5EW37CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJUGEZTEOBVHE>. You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>

[caio-chagas-intuitivecare]

@rbicelli Will you make some change on script for this case?

[mrosu-sp]

Are not many people having this issue because pfSense is throwing errors every 30 minutes and piling on the Notices.

Are other people just dealing with it or is there a workaround that everyone else is using?

I would prefer not to have to shut down zabbix agent on the routers.

[rbicelli]

Hello,
pfSense code in commercial versions has some differences with free version, which is that I'm using. Since that PR are welcome.

In 2.7.2 I'm not experiencing problems with SMART related functions.
You don't have necessarily shut down the zabbix agent, you could just disable SMART Status item in the template:

However I found this check pretty useless: I had a couple SSD drive fails without notice in Zabbix (due to UFS filesystem corruption which SMART cannot detect).

[mrosu-sp]

Oh I see, we am using the commercial version.

Yeah I'm not concerned about the SMART status honestly; they're on raid1 anyway, so we can take a drive failure. It's a lot of all of the other data that we use.

I disabled the SMART Status check in Zabbix. I didn't realize disabling that would actually prevent the item check on the host even if it's an active checks. I learned something today.

Thanks very much.

[grantemsley]

pfSense CE is now affected by this as of 2.8.0.

I can confirm editing the file to remove 'smart_' from 'get_smart_drive_list()' fixes it on both CE 2.8.0 and Plus 24.11.