Skip to content

[runtime_env] Reference counter doesn't handle multiple options using the same URI #52578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edoakes opened this issue Apr 24, 2025 · 0 comments
Assignees
Labels
bug Something that is supposed to be working; but isn't core Issues that should be addressed in Ray Core jira-core P1 Issue that should be fixed within a few weeks

Comments

@edoakes
Copy link
Collaborator

edoakes commented Apr 24, 2025

What happened + What you expected to happen

When setting working_dir and py_modules to the same URI within the same runtime_env, only one of them will be GC'd. I added logs in the runtime_env agent, and it appears to call the deletion callback twice on ("py_modules", URI) instead of once on ("py_modules", URI) and once on ("working_dir", URI) as expected.

I haven't dug too deep yet, but it appears to be caused by the fact that this dictionary is keyed on URI only, not the (option, URI) tuple.

Versions / Dependencies

Master

Reproduction script

See the comment on test_runtime_env_working_dir_3::TestGC::test_actor_level_gc added here: #52553

@edoakes edoakes added bug Something that is supposed to be working; but isn't core Issues that should be addressed in Ray Core P1 Issue that should be fixed within a few weeks labels Apr 24, 2025
@israbbani israbbani self-assigned this Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to be working; but isn't core Issues that should be addressed in Ray Core jira-core P1 Issue that should be fixed within a few weeks
Projects
None yet
Development

No branches or pull requests

2 participants