Skip to content

Commit c79a3de

Browse files
authored
[Dashboard] Remove millisecond padding in DurationText component (#52395)
Signed-off-by: chuang0221 <chuangellow@gmail.com>
1 parent 60ed6fd commit c79a3de

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

python/ray/dashboard/client/src/common/DurationText/DurationText.component.test.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,11 @@ describe("DurationText", () => {
1313
rerender(
1414
<DurationText startTime={new Date(100000)} endTime={new Date(105000)} />,
1515
);
16-
expect(await screen.findByText("5s 000ms")).toBeInTheDocument();
16+
expect(await screen.findByText("5s 0ms")).toBeInTheDocument();
1717
rerender(
1818
<DurationText startTime={new Date(100000)} endTime={new Date(110000)} />,
1919
);
20-
expect(await screen.findByText("10s 000ms")).toBeInTheDocument();
20+
expect(await screen.findByText("10s 0ms")).toBeInTheDocument();
2121
rerender(
2222
<DurationText startTime={new Date(100000)} endTime={new Date(200000)} />,
2323
);
@@ -69,13 +69,13 @@ describe("DurationText", () => {
6969

7070
MockDate.set(mockDate1);
7171
const { rerender } = render(<DurationText startTime={startTime} />);
72-
expect(await screen.findByText("5s 000ms")).toBeInTheDocument();
72+
expect(await screen.findByText("5s 0ms")).toBeInTheDocument();
7373

7474
MockDate.set(mockDate2);
7575
act(() => {
7676
jest.advanceTimersByTime(1000);
7777
});
78-
expect(await screen.findByText("6s 000ms")).toBeInTheDocument();
78+
expect(await screen.findByText("6s 0ms")).toBeInTheDocument();
7979

8080
MockDate.set(mockDate3);
8181
act(() => {

python/ray/dashboard/client/src/common/DurationText/DurationText.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,10 @@ export const DurationText = ({ startTime, endTime }: DurationTextProps) => {
2828
let durationText: string;
2929
let refreshInterval = 1000;
3030
if (duration.asSeconds() < 1) {
31-
durationText = duration.format("SSS[ms]");
31+
durationText = duration.milliseconds() + "ms";
3232
} else if (duration.asMinutes() < 1) {
33-
durationText = duration.format("s[s] SSS[ms]");
33+
durationText =
34+
duration.format("s[s]") + " " + duration.milliseconds() + "ms";
3435
} else if (duration.asHours() < 1) {
3536
durationText = duration.format("m[m] s[s]");
3637
} else if (duration.asDays() < 1) {

0 commit comments

Comments
 (0)