Skip to content

Commit bf7f085

Browse files
authored
[core] [easy] [no-op] Fix rotation comment (#51606)
The correct destination is stderr but not stdout. - We've mentioned effect to stream to stderr here: https://github.com/ray-project/ray/blob/a42e6580a59dff3291a56595a74ff27c04d9e29d/python/ray/_private/services.py#L1142-L1144 - Stream handler is used when logging filename not specified, which streams to stderr: https://docs.python.org/3/library/logging.handlers.html#logging.StreamHandler Signed-off-by: dentiny <dentinyhao@gmail.com>
1 parent 41e3b38 commit bf7f085

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

python/ray/_private/log_monitor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -516,7 +516,7 @@ def is_proc_alive(pid):
516516
type=str,
517517
default=ray_constants.LOG_MONITOR_LOG_FILE_NAME,
518518
help="Specify the name of log file, "
519-
"log to stdout if set empty, default is "
519+
"log to stderr if set empty, default is "
520520
f'"{ray_constants.LOG_MONITOR_LOG_FILE_NAME}"',
521521
)
522522
parser.add_argument(

0 commit comments

Comments
 (0)