Skip to content

Commit 9689901

Browse files
authored
Remove unused test utils (#51339)
Cleaning up dead code that I noticed while working on `_common/` dir refactoring. --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
1 parent 2f5c5d8 commit 9689901

14 files changed

+195
-384
lines changed

python/ray/_private/test_utils.py

Lines changed: 62 additions & 289 deletions
Large diffs are not rendered by default.

python/ray/dashboard/modules/event/tests/test_generate_export_events.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
import ray
1515
from ray._private.gcs_utils import GcsAioClient
16-
from ray._private.test_utils import async_wait_for_condition_async_predicate
16+
from ray._private.test_utils import async_wait_for_condition
1717
from ray.dashboard.modules.job.job_manager import JobManager
1818
from ray.job_submission import JobStatus
1919
from ray.tests.conftest import call_ray_start # noqa: F401
@@ -172,7 +172,7 @@ async def test_submission_job_export_events(call_ray_start, tmp_path): # noqa:
172172
)
173173

174174
# Wait for the job to be finished.
175-
await async_wait_for_condition_async_predicate(
175+
await async_wait_for_condition(
176176
check_job_succeeded, job_manager=job_manager, job_id=submission_id
177177
)
178178

python/ray/dashboard/modules/job/tests/test_job_agent.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
from ray._private.runtime_env.py_modules import upload_py_modules_if_needed
1818
from ray._private.runtime_env.working_dir import upload_working_dir_if_needed
1919
from ray._private.test_utils import (
20-
async_wait_for_condition_async_predicate,
20+
async_wait_for_condition,
2121
chdir,
2222
format_web_url,
2323
get_current_unused_port,
@@ -643,7 +643,7 @@ async def verify():
643643

644644
return True
645645

646-
await async_wait_for_condition_async_predicate(verify, retry_interval_ms=2000)
646+
await async_wait_for_condition(verify, retry_interval_ms=2000)
647647
finally:
648648
subprocess.check_output("ray stop --force", shell=True)
649649

0 commit comments

Comments
 (0)