Skip to content

Commit 8a77a92

Browse files
authored
[core] Correct the wording in the OnNodeDead logs to avoid confusion (#51668)
Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>
1 parent 0d01ce6 commit 8a77a92

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

src/ray/gcs/gcs_server/gcs_actor_manager.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1294,7 +1294,7 @@ void GcsActorManager::OnWorkerDead(const ray::NodeID &node_id,
12941294
void GcsActorManager::OnNodeDead(std::shared_ptr<rpc::GcsNodeInfo> node,
12951295
const std::string node_ip_address) {
12961296
const auto node_id = NodeID::FromBinary(node->node_id());
1297-
RAY_LOG(INFO).WithField(node_id) << "Node failed, reconstructing actors.";
1297+
RAY_LOG(INFO).WithField(node_id) << "Node is dead, reconstructing actors.";
12981298
// Kill all children of owner actors on a dead node.
12991299
const auto it = owners_.find(node_id);
13001300
if (it != owners_.end()) {

src/ray/gcs/gcs_server/gcs_job_manager.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -472,7 +472,7 @@ std::shared_ptr<rpc::JobConfig> GcsJobManager::GetJobConfig(const JobID &job_id)
472472

473473
void GcsJobManager::OnNodeDead(const NodeID &node_id) {
474474
RAY_LOG(INFO).WithField(node_id)
475-
<< "Node failed, mark all jobs from this node as finished";
475+
<< "Node is dead, mark all jobs from this node as finished";
476476

477477
auto on_done = [this,
478478
node_id](const absl::flat_hash_map<JobID, rpc::JobTableData> &result) {

src/ray/gcs/gcs_server/gcs_placement_group_manager.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -801,7 +801,7 @@ GcsPlacementGroupManager::GetBundlesOnNode(const NodeID &node_id) const {
801801

802802
void GcsPlacementGroupManager::OnNodeDead(const NodeID &node_id) {
803803
RAY_LOG(INFO).WithField(node_id)
804-
<< "Node failed, rescheduling the placement groups on the dead node.";
804+
<< "Node is dead, rescheduling the placement groups on the dead node.";
805805
auto bundles = gcs_placement_group_scheduler_->GetAndRemoveBundlesOnNode(node_id);
806806
for (const auto &bundle : bundles) {
807807
auto iter = registered_placement_groups_.find(bundle.first);

0 commit comments

Comments
 (0)