[Core] Cover cpplint for ray/src/ray/raylet (#51399)

Ensure all `.h` and `.cc` files in `src/ray/raylet` comply with cpplint
rules.
Note: `scheduling` folder is not included

Closes: #50687 

---------

Signed-off-by: 400Ping <43886578+400Ping@users.noreply.github.com>
Signed-off-by: Ping <43886578+400Ping@users.noreply.github.com>

Author: 400Ping

.pre-commit-config.yaml

@@ -47,7 +47,8 @@ repos:
     hooks:
       - id: cpplint
         args: ["--filter=-whitespace/braces,-whitespace/line_length,-build/c++11,-build/c++14,-build/c++17,-readability/braces,-whitespace/indent_namespace,-runtime/int,-runtime/references,-build/include_order"]
-        files: ^src/ray/(util|raylet_client|internal|scheduling|pubsub|object_manager|gcs|rpc(?:/.*)?)/.*\.(h|cc)$
+        files: ^src/ray/(util|raylet_client|internal|scheduling|pubsub|object_manager|rpc(?:/.*)?|raylet)/.*\.(h|cc)$
+        exclude: ^src/ray/raylet/scheduling/.*\.(h|cc)$
 
   - repo: https://github.com/keith/pre-commit-buildifier
     rev: 8.0.1

src/ray/raylet/agent_manager.cc

@@ -14,7 +14,10 @@
 
 #include "ray/raylet/agent_manager.h"
 
+#include <memory>
+#include <string>
 #include <thread>
+#include <vector>
 
 #include "ray/common/ray_config.h"
 #include "ray/util/event.h"

src/ray/raylet/agent_manager.h

@@ -17,6 +17,7 @@
 #include <atomic>
 #include <boost/asio/deadline_timer.hpp>
 #include <csignal>
+#include <memory>
 #include <string>
 #include <utility>
 #include <vector>

src/ray/raylet/dependency_manager.cc

@@ -14,6 +14,11 @@
 
 #include "ray/raylet/dependency_manager.h"
 
+#include <memory>
+#include <string>
+#include <utility>
+#include <vector>
+
 namespace ray {
 
 namespace raylet {

src/ray/raylet/dependency_manager.h

@@ -14,6 +14,12 @@
 
 #pragma once
 
+#include <memory>
+#include <string>
+#include <unordered_set>
+#include <utility>
+#include <vector>
+
 #include "ray/common/common_protocol.h"
 #include "ray/common/id.h"
 #include "ray/common/task/task.h"
@@ -49,7 +55,7 @@ class TaskDependencyManagerInterface {
 class DependencyManager : public TaskDependencyManagerInterface {
  public:
   /// Create a task dependency manager.
-  DependencyManager(ObjectManagerInterface &object_manager)
+  explicit DependencyManager(ObjectManagerInterface &object_manager)
       : object_manager_(object_manager) {
     waiting_tasks_counter_.SetOnChangeCallback(
         [this](std::pair<std::string, bool> key) mutable {
@@ -200,7 +206,7 @@ class DependencyManager : public TaskDependencyManagerInterface {
   /// Metadata for an object that is needed by at least one executing worker
   /// and/or one queued task.
   struct ObjectDependencies {
-    ObjectDependencies(const rpc::ObjectReference &ref)
+    explicit ObjectDependencies(const rpc::ObjectReference &ref)
         : owner_address(ref.owner_address()) {}
     /// The tasks that depend on this object, either because the object is a task argument
     /// or because the task called `ray.get` on the object.

src/ray/raylet/dependency_manager_test.cc

@@ -15,6 +15,10 @@
 #include "ray/raylet/dependency_manager.h"
 
 #include <list>
+#include <string>
+#include <unordered_set>
+#include <utility>
+#include <vector>
 
 #include "gmock/gmock.h"
 #include "gtest/gtest.h"
@@ -82,7 +86,7 @@ class DependencyManagerTest : public ::testing::Test {
     ASSERT_TRUE(dependency_manager_.queued_task_requests_.empty());
     ASSERT_TRUE(dependency_manager_.get_requests_.empty());
     ASSERT_TRUE(dependency_manager_.wait_requests_.empty());
-    ASSERT_TRUE(dependency_manager_.waiting_tasks_counter_.Total() == 0);
+    ASSERT_EQ(dependency_manager_.waiting_tasks_counter_.Total(), 0);
     // All pull requests are canceled.
     ASSERT_TRUE(object_manager_mock_.active_task_requests.empty());
     ASSERT_TRUE(object_manager_mock_.active_get_requests.empty());

src/ray/raylet/local_object_manager.cc

@@ -14,6 +14,12 @@
 
 #include "ray/raylet/local_object_manager.h"
 
+#include <algorithm>
+#include <memory>
+#include <string>
+#include <utility>
+#include <vector>
+
 #include "ray/common/asio/instrumented_io_context.h"
 #include "ray/stats/metric_defs.h"
 #include "ray/util/util.h"

src/ray/raylet/local_object_manager.h

@@ -17,6 +17,10 @@
 #include <google/protobuf/repeated_field.h>
 
 #include <functional>
+#include <memory>
+#include <queue>
+#include <string>
+#include <vector>
 
 #include "ray/common/id.h"
 #include "ray/common/ray_object.h"

src/ray/raylet/local_task_manager.cc

@@ -16,7 +16,13 @@
 
 #include <google/protobuf/map.h>
 
+#include <algorithm>
 #include <boost/range/join.hpp>
+#include <limits>
+#include <memory>
+#include <string>
+#include <utility>
+#include <vector>
 
 #include "ray/stats/metric_defs.h"
 #include "ray/util/logging.h"

src/ray/raylet/local_task_manager.h

@@ -14,6 +14,13 @@
 
 #pragma once
 
+#include <deque>
+#include <list>
+#include <memory>
+#include <string>
+#include <utility>
+#include <vector>
+
 #include "absl/container/flat_hash_map.h"
 #include "absl/container/flat_hash_set.h"
 #include "ray/common/ray_object.h"
@@ -87,7 +94,7 @@ class LocalTaskManager : public ILocalTaskManager {
           get_task_arguments,
       size_t max_pinned_task_arguments_bytes,
       std::function<int64_t(void)> get_time_ms =
-          []() { return (int64_t)(absl::GetCurrentTimeNanos() / 1e6); },
+          []() { return static_cast<int64_t>(absl::GetCurrentTimeNanos() / 1e6); },
       int64_t sched_cls_cap_interval_ms =
           RayConfig::instance().worker_cap_initial_backoff_delay_ms());
 
@@ -292,7 +299,7 @@ class LocalTaskManager : public ILocalTaskManager {
   /// class. This information is used to place a cap on the number of running
   /// running tasks per scheduling class.
   struct SchedulingClassInfo {
-    SchedulingClassInfo(int64_t cap)
+    explicit SchedulingClassInfo(int64_t cap)
         : running_tasks(),
           capacity(cap),
           next_update_time(std::numeric_limits<int64_t>::max()) {}